Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using comment blocks before the <html> tag breaks layout in IE8 #751

Closed
alex-ju opened this issue Jun 1, 2018 · 4 comments
Closed

Using comment blocks before the <html> tag breaks layout in IE8 #751

alex-ju opened this issue Jun 1, 2018 · 4 comments
Labels
🔍 investigation

Comments

@alex-ju
Copy link
Contributor

alex-ju commented Jun 1, 2018 •
edited
Loading

Using comment blocks (e.g. <!-- block:pageStart -->) before the <html> tag is breaking the template examples layout in IE8.

With <!-- block:pageStart -->

screen shot 2018-06-01 at 17 21 17

Without <!-- block:pageStart -->

screen shot 2018-06-01 at 17 21 58
@NickColley
Copy link
Contributor

What is the need for this block? Can you put anything before the doctype without it breaking?

If not, we should probably remove this.

@kr8n3r
Copy link

kr8n3r commented Jun 5, 2018 •
edited
Loading

in non html5 documents you could have something before doctype
"Anything before the DOCTYPE, like a comment or an XML declaration will trigger quirks mode in Internet Explorer 9 and older."

since we're all about html5, let's remove it

@NickColley
Copy link
Contributor

Would this be a problem if we added <meta http-equiv="x-ua-compatible" content="ie=edge"> to template?

@kr8n3r
Copy link

kr8n3r commented Jun 5, 2018 •
edited
Loading

no, that fixes it, but there is a minimal performance impact
"If you are using the X-UA-Compatible META tag you want to place it as close to the top of the page's HEAD as possible. ... When Internet Explorer encounters the X-UA-Compatible META tag it starts over using the designated version's engine. This is a performance hit because the browser must stop and restart analyzing the content."

see more discussion here
google/web-starter-kit#728

@NickColley NickColley mentioned this issue Jun 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🔍 investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alex-ju @NickColley @kr8n3r