Fix focus outline style in Chrome and Safari #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives us a single place to define how focusable form elements should behave when focussed. Chrome and Safari set outline-offset to -2px for focussed textareas, selects and inputs, so we need to reset to 0 so that the outline appears consistently outside of the border rather than overlaying it.
alex-ju
approved these changes
Jan 8, 2018
This was referenced Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome and Safari set outline-offset to -2px for focussed textareas, selects and inputs, so we need to reset to 0 so that the outline appears consistently outside of the border rather than overlaying it.
As part of this, move the focus style into a helper to avoid defining the focus style in multiple places.
https://trello.com/c/GwwOrcyB/539-focus-outline-style-should-be-offset-from-border-not-overlapping
Input
Textarea
Select
No change - the select focus state already included
outline-offset: 0Error Summary (no change)
No change - the user agent stylesheet does not set outline-offset for the focus state of a div.
File Upload (no change)
No change - the user agent stylesheet already resets outline-offset to
0for the focus state of a input of typefile.