chore(packages): copy changes to packages #421
Conversation
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-421
packages/all/package.json
Outdated
| @@ -1,31 +1,31 @@ | |||
| { | |||
| "name": "@govuk-frontend/all", | |||
| "version": "0.0.19-alpha", | |||
| "version": "0.0.20-alpha", | |||
There was a problem hiding this comment.
Is this normally done by lerna? Do we need to do this manually?
There was a problem hiding this comment.
👍 After consulting Lerna documentation it appears it's not necessary to change package.json manually. Have taken this out.
hannalaakso
force-pushed
the
update-publish-and-packages-10-jan-18
branch
from
e36cb87
to
1f7b816
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-421
| @@ -5,7 +5,7 @@ | |||
| "@govuk-frontend/back-link": "^0.0.19-alpha", | |||
| "@govuk-frontend/breadcrumbs": "^0.0.19-alpha", | |||
| "@govuk-frontend/button": "^0.0.19-alpha", | |||
| "@govuk-frontend/checkbox": "^0.0.19-alpha", | |||
| "@govuk-frontend/checkboxes": "^0.0.20-alpha", | |||
There was a problem hiding this comment.
Is this bump intentional when renaming?
There was a problem hiding this comment.
As far as npm is concerned, we've published a new package, not renamed one.
@NickColley was looking into this and added a note to dev time to discuss how we should handle removing npm packages such as govuk-frontend/checkbox
| @@ -55,6 +63,21 @@ | |||
| color: $govuk-text-colour; | |||
| } | |||
| } | |||
|
|
|||
| // The following adjustments do not work for <input type="button"> as | |||
There was a problem hiding this comment.
So I think postcss-nested is doing crazy things here. It's removed the nesting of the ::before and ::active::before by shunting them down the file, taking the immediately preceding comment line, but leaving the rest of the comment here, divorced from its context.
Not sure what we can do about this in the short term, but… this is not great.
There was a problem hiding this comment.
As just discussed in person, we should review why we're using postcss-nested when @igloosi is back.
|
|
||
| background: transparent; | ||
| } | ||
| // 🎉 |
src/components/radios/package.json
Outdated
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
I don't think this is meant to be added? None of the other components have package.json files in the src directory.
There was a problem hiding this comment.
Yes indeed. I've taken it out.
hannalaakso
force-pushed
the
update-publish-and-packages-10-jan-18
branch
from
1f7b816
to
a87bd74
Compare
…jan-18 Fix to #421 - restore correct FE version for radios and checkboxes
Update with all the latest changes from source:
widthclasses, which were based onform-controlclasses that werespecific to form control in Elements. (PR #413)
Note: this step of the publishing process is not perfect right now, it's hard to check that this contains the correct changes. We will have some tests eventually to verify.