Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix focus outline style in Chrome and Safari #414

Merged
merged 3 commits into from
Jan 8, 2018
Merged

Fix focus outline style in Chrome and Safari #414

merged 3 commits into from
Jan 8, 2018
+13 −23

Commits on Jan 5, 2018

  1. Add a ‘focusable’ helper 

    This gives us a single place to define how focusable form elements should behave when focussed.

Chrome and Safari set outline-offset to -2px for focussed textareas, selects and inputs, so we need to reset to 0 so that the outline appears consistently outside of the border rather than overlaying it.
    @36degrees
    36degrees committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    690c76f View commit details
    Browse the repository at this point in the history

  2. Update form components to use focusable helper

    @36degrees
    36degrees committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    17c484e View commit details
    Browse the repository at this point in the history

  3. Update error summary component to use focusable helper

    @36degrees
    36degrees committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    9fb4f25 View commit details
    Browse the repository at this point in the history