Update release notes for removing deprecated $govuk-border-width-form-element-error variable
#2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2380
36degrees
reviewed
Oct 14, 2021
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2380
vanitabarrett
commented
Oct 14, 2021
vanitabarrett
force-pushed
the
tweak-error-border-changelog
branch
from
0c7c9bb
to
0749dde
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2380
|
@EoinShaughnessy I've made some changes following Ollie's comment - would you be ok to have another look at the changes? |
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2380
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2380
|
@vanitabarrett @36degrees Do we need to change the title of both this pull request and #1963 to include the word 'variable'? |
vanitabarrett
changed the title
$govuk-border-width-form-element-error variable
vanitabarrett
commented
Oct 14, 2021
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2380
vanitabarrett
force-pushed
the
tweak-error-border-changelog
branch
from
0414199
to
0ef1b73
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2380
|
@36degrees Are you happy to approve this PR? |
36degrees
reviewed
Oct 14, 2021
vanitabarrett
force-pushed
the
tweak-error-border-changelog
branch
from
0ef1b73
to
816b32a
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2380
36degrees
approved these changes
Oct 14, 2021
vanitabarrett
force-pushed
the
tweak-error-border-changelog
branch
from
816b32a
to
4b1451b
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-2380
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expand on the release notes for pull request 1963: Remove deprecated
$govuk-border-width-form-element-errorsetting so it's clearer what users need to do as a result of this change.cc @EoinShaughnessy for visibility - this has already been drafted in the v4.0.0 draft release notes document