Remove deprecated $govuk-border-width-form-element-error variable
#1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1963
hannalaakso
approved these changes
Sep 22, 2020
|
Minor wording thing: We already deprecated I think this mostly affects the release note, but it'd be good to update the PR title. I don't think it's enough of an issue to worry about the branch name? |
vanitabarrett
changed the title
vanitabarrett
force-pushed
the
deprecate-border-width-error
branch
from
977367e
to
e1a05c5
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-1963
vanitabarrett
force-pushed
the
deprecate-border-width-error
branch
from
e1a05c5
to
9f0fe5e
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-fronte-deprecate--yiwqlg
EoinShaughnessy
changed the title
$govuk-border-width-form-element-error
vanitabarrett
force-pushed
the
deprecate-border-width-error
branch
from
9f0fe5e
to
ac76335
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-1963
vanitabarrett
force-pushed
the
deprecate-border-width-error
branch
from
ac76335
to
98a0437
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-1963
4 tasks
vanitabarrett
changed the title
$govuk-border-width-form-element-error$govuk-border-width-form-element-error variable
36degrees
added a commit
that referenced
this pull request
Oct 27, 2021
Also tweak the note for #2370 and #1963 so that we're talk about the removal of deprecated features consistently. Co-authored-by: Eoin Shaughnessy <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1871
This change is related to #1870