Skip to content

Commit

Permalink
Tweaks from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
Vanita Barrett committed Oct 14, 2021
1 parent 5a8640b commit 0749dde
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,11 @@
You must make the following changes when you migrate to this release, or your service may break.

#### Remove deprecated $govuk-border-width-form-element-error
The [border width of form elements in their error state](https://github.com/alphagov/govuk-frontend/pull/1870) is now the same as form elements in their normal state.
In v3.8.0, we made the [border width of form elements in their error state](https://github.com/alphagov/govuk-frontend/pull/1870) the same as form elements in their normal state and deprecated `$govuk-border-width-form-element-error`.

To make this change, we've removed the `$govuk-border-width-form-element-error` setting.
We've now removed `$govuk-border-width-form-element-error` completely.

If you’re referencing `$govuk-border-width-form-element-error` (for example, in your own components), you must remove this setting. Otherwise, if users changed the `$govuk-border-width-form-element`, you would have to conditionally add overrides to maintain a consistent focus state.

You can still change the border colour. For example, you can replace `border: $govuk-border-width-form-element-error solid $govuk-error-colour;` with `border-color: $govuk-error-colour;`.
If you’re referencing `$govuk-border-width-form-element-error` in your own Sass, you must remove this setting. If you are defining your own error state, you only need to change the border colour. You should avoid overriding the border thickness. For example, replace `border: $govuk-border-width-form-element-error solid $govuk-error-colour;` with `border-color: $govuk-error-colour;`.

If you’re overriding `$govuk-border-width-form-element-error` in your CSS, this will no longer work - so we advise you to remove this override.

Expand Down

0 comments on commit 0749dde

Please sign in to comment.