Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aria labelledby to alert notification banners #2020

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Add aria labelledby to alert notification banners #2020

merged 1 commit into from
Nov 18, 2020

Commits on Nov 18, 2020

  1. Add aria-labelledby to alert banners 

    NOTE: this PR does not update the macro documentation - this will be done separately in #2001

We have decided to keep the aria-labelledby attribute on alert banners too, to make things consistent with the error summary. We were seeing some odd behaviour when testing with NVDA and Voiceover, but this change did not seem to have a negative impact and it also means that when we next revisit the component we're at least working from a place where everything is consistent to start with.
    Vanita Barrett committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    6db2e47 View commit details
    Browse the repository at this point in the history