Add aria labelledby to alert notification banners #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-2020
vanitabarrett
changed the base branch from
master
to
feature/notification-banner
vanitabarrett
force-pushed
the
add-aria-labelledby
branch
from
8d21715
to
95a1a30
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-2020
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-2020
NOTE: this PR does not update the macro documentation - this will be done separately in #2001 We have decided to keep the aria-labelledby attribute on alert banners too, to make things consistent with the error summary. We were seeing some odd behaviour when testing with NVDA and Voiceover, but this change did not seem to have a negative impact and it also means that when we next revisit the component we're at least working from a place where everything is consistent to start with.
vanitabarrett
force-pushed
the
add-aria-labelledby
branch
from
1814ce0
to
5322ecb
Compare
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-2020
vanitabarrett
changed the title
vanitabarrett
force-pushed
the
add-aria-labelledby
branch
from
5322ecb
to
6db2e47
Compare
|
Good point @36degrees , I've raised a new PR here #2022 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1954