Update nunjucks param descriptions for the notification banner component #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-2001
src/govuk/components/notification-banner/notification-banner.yaml
Outdated
Show resolved
Hide resolved
|
Thanks @EoinShaughnessy 👍 @vanitabarrett or @36degrees I wonder if you might be able to review this one as I worked on the content changes with Eion. |
36degrees
changed the title
src/govuk/components/notification-banner/notification-banner.yaml
Outdated
Show resolved
Hide resolved
src/govuk/components/notification-banner/notification-banner.yaml
Outdated
Show resolved
Hide resolved
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-2001
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-2001
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-2001
|
@vanitabarrett Hi! I've added your edits into the content. Do I now need to tidy the trail of commits somehow? |
src/govuk/components/notification-banner/notification-banner.yaml
Outdated
Show resolved
Hide resolved
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-2001
vanitabarrett
approved these changes
Nov 13, 2020
EoinShaughnessy
force-pushed
the
notification-banner-eoin-nunjucks-edit
branch
from
676032c
to
093bc70
Compare
vanitabarrett
pushed a commit
that referenced
this pull request
Nov 18, 2020
NOTE: this PR does not update the macro documentation - this will be done separately in #2001 We have decided to keep the aria-labelledby attribute on alert banners too, to make things consistent with the error summary. We were seeing some odd behaviour when testing with NVDA and Voiceover, but this change did not seem to have a negative impact and it also means that when we next revisit the component we're at least working from a place where everything is consistent to start with.
|
Superseded by #2024 |
vanitabarrett
pushed a commit
that referenced
this pull request
Nov 23, 2020
NOTE: this PR does not update the macro documentation - this will be done separately in #2001 We have decided to keep the aria-labelledby attribute on alert banners too, to make things consistent with the error summary. We were seeing some odd behaviour when testing with NVDA and Voiceover, but this change did not seem to have a negative impact and it also means that when we next revisit the component we're at least working from a place where everything is consistent to start with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced some instances of the passive voice with the active voice, and inserted the word "you" at various points. This was to make the content more immediate and personalise it a tad for users.
I also reordered some sentences. This was to frontload info about the purpose of the options.
Please holler at me re any follow-up questions! :)
Fixes #1997