Allow extra form group classes on all form components #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've followed the same naming conventions as @igloosi and hidden the new examples from the readmes. |
|
This is ace @colinrotherham 🎉 Looks good, checked out the PR and ran locally. Need second dev to approve it. Also fixes: #1042 |
NickColley
approved these changes
Nov 7, 2018
|
Epic, the CHANGELOG needs adjusting slightly and I think we can merge this. |
|
thanks @colinrotherham I was going to try and get around to doing a PR this week, but now I don't have to 👍 |
Merged
chrimesdev
added a commit
to nhsuk/nhsuk-frontend
that referenced
this pull request
Nov 22, 2018
Allow extra form group classes on all form components, which were originally just on radios and and checkboxes. alphagov/govuk-frontend#1059
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm updating a service to the new design system and we need classes on
form-groupitems.I saw this was added recently, but yes we need them on more components than just radio/checkbox! 😊 (You guessed it @NickColley #1043 (comment))
This adds
formGroup: { classes: 'extra-class' }support to:Which follows on nicely from #1043 that added:
Thanks