Params to allow classes for govuk-form-group

[web-bert]

When using the govukSelect macro it would be nice to have a param for adding classes to the govuk-form-group

I am working on a design where we want to add a background colour to the select and label, rather than having to add a wrapping element or use a generic selector, it would be good to be able to target the form group specifically.

I would suggest:

  {{ govukSelect({
    group: {
      classes: 'my-custom-class'
    }
  }) }}

I am not sure if there are other macros that could use the same treatment...

[kr8n3r]

Hi @web-bert, thanks for raising this. A while ago we had a similar issue open, but closed it due to lack of interest. However, what you're describing has recently been mentioned, so we're going to discuss this as a team early next week.

We will update the this issue to let you know of the outcome.

[web-bert]

Ok great. Happy to raise a PR if you can give some guidance on the components affected and the desired param names etc

[kr8n3r]

Hi @web-bert,
we've decided to go with a similar syntax as you outlined above in #1043

We opted for

formGroup: { 
   classes: ''
} 

I'd imagine Select, file upload, input, textarea and date input would be candidates as they all contain the form group wrapper.

You can have a look in the linked radios and checkboxes work to see how we now declare macro params(options). I don't think these examples need to be in the review app or readme files.

I'd suggest a single PR per component for easier review, but also opened to a single PR for all components with meaningful commits that will make it a bit easier to follow.

[kr8n3r]

addressed by #1059