Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form elements #206

Closed
chrimesdev opened this issue Nov 15, 2018 · 0 comments
Closed

Form elements #206

chrimesdev opened this issue Nov 15, 2018 · 0 comments
Assignees
@chrimesdev @davidhunter08

Comments

@chrimesdev
Copy link
Member

Add form elements to the NHS.UK Frontend. To begin with we will be using GOV.UK elements and then modifying them with our styles to suit our user needs.
chrimesdev added a commit that referenced this issue Nov 15, 2018
@chrimesdev
[refs #206] add all GOV.UK form elements
d7cb2ba 
Add all of the GOV.UK form elements with individual examples, macros
and documentation. Ready for overlaying the NHS styles to create our
own form elements.
chrimesdev added a commit that referenced this issue Nov 15, 2018
@chrimesdev
[refs #206] Form elements linting and code comments
b2eb0fd 
Fix the scss linting issues for the form elements and also add
code comments in the correct format.
chrimesdev added a commit that referenced this issue Nov 17, 2018
@chrimesdev
[refs #206] Form elements linting and code comments
8cfbfb2 
Fix the scss linting issues for the form elements and also add
code comments in the correct format.
chrimesdev added a commit that referenced this issue Nov 18, 2018
@chrimesdev
[refs #206] Form elements linting and code comments
d5b3b47 
Fix the scss linting issues for the form elements and also add
code comments in the correct format.
chrimesdev added a commit that referenced this issue Nov 18, 2018
@chrimesdev
[refs #206] links to form elements examples and GitHub issues
a6bdd57 
Add links to all the form elements example variants and
GitHub issue for discussion.
chrimesdev added a commit that referenced this issue Nov 19, 2018
@chrimesdev
[refs #206] Remove temporary form element variables
e1f0374 
Remove the temporary form element variables for border sizing
and element sizing.
chrimesdev added a commit that referenced this issue Nov 19, 2018
@chrimesdev
[refs #206] Form element nunjucks macro argument table
89416d8 
Add the nunjucks macro arguments table, to documentat what
arguments of the form element macros take.
chrimesdev added a commit that referenced this issue Nov 19, 2018
@chrimesdev
[refs #206] Transactional header with service name
a4938cd 
Add styles for a transactional header with a service name and update
the nunjucks macro to pass through parameters for the service name and
href. Create an example page.
chrimesdev added a commit that referenced this issue Nov 19, 2018
@chrimesdev
[refs #206] add all GOV.UK form elements
40a2a72 
Add all of the GOV.UK form elements with individual examples, macros
and documentation. Ready for overlaying the NHS styles to create our
own form elements.
chrimesdev added a commit that referenced this issue Nov 19, 2018
@chrimesdev
[refs #206] Form elements linting and code comments
5337f3a 
Fix the scss linting issues for the form elements and also add
code comments in the correct format.
chrimesdev added a commit that referenced this issue Nov 19, 2018
@chrimesdev
[refs #206] links to form elements examples and GitHub issues
73533e7 
Add links to all the form elements example variants and
GitHub issue for discussion.
chrimesdev added a commit that referenced this issue Nov 19, 2018
@chrimesdev
[refs #206] Remove temporary form element variables
68b98dd 
Remove the temporary form element variables for border sizing
and element sizing.
chrimesdev added a commit that referenced this issue Nov 19, 2018
@chrimesdev
[refs #206] Form element nunjucks macro argument table
ddc60bf 
Add the nunjucks macro arguments table, to documentat what
arguments of the form element macros take.
chrimesdev added a commit that referenced this issue Nov 19, 2018
@chrimesdev
[refs #206] Transactional header with service name
c19649c 
Add styles for a transactional header with a service name and update
the nunjucks macro to pass through parameters for the service name and
href. Create an example page.
chrimesdev added a commit that referenced this issue Nov 19, 2018
@chrimesdev
[refs #206] Transactional header with service name
6446084 
Add styles for a transactional header with a service name and update
the nunjucks macro to pass through parameters for the service name and
href. Create an example page.
davidhunter08 added a commit that referenced this issue Nov 21, 2018
@davidhunter08
[refs #206] Form elements styling
cdbb413 
Started to add new NHS form styles to the form elements.
Created a test page 'forms.njk' to replicate the teams designs.
davidhunter08 added a commit that referenced this issue Nov 21, 2018
@davidhunter08
[refs #206] Ndop test page and button focus
cca0caf 
Added test page for ndop.
Changed nhsuk-focusable mixin to use box-shadow instead of outline.
This has fixed the focus issue on the button.
davidhunter08 added a commit that referenced this issue Nov 21, 2018
@davidhunter08
[refs #206] Updated button padding
60e8504
davidhunter08 added a commit that referenced this issue Nov 21, 2018
@davidhunter08
[refs #206] Transactional header, radios and checkboxes
a3c598f
davidhunter08 added a commit that referenced this issue Nov 21, 2018
@davidhunter08
[refs #206] Error summary and service header
534faba 
Updated the error link colour on hover.
Changed the service name font-weight to regular.
Also removed redundant link on components page.
davidhunter08 added a commit that referenced this issue Nov 21, 2018
@davidhunter08
[refs #206] Form group margin
2858832 
Reduced form group margin-bottom.
davidhunter08 added a commit that referenced this issue Nov 21, 2018
@davidhunter08
[refs #206] Form group wrapper
6395b21 
Added a class of `nhsuk-form-group--wrapper ` to give the spacing
we need at the bottom of forms.
davidhunter08 added a commit that referenced this issue Nov 21, 2018
@davidhunter08
[refs #206] Added transactional test pages
cd23e04
chrimesdev added a commit that referenced this issue Nov 22, 2018
@chrimesdev
[refs #206] Allow extra form group classes on form components
e4421a1 
Allow extra form group classes on all form components, which were
originally just on radios and and checkboxes.
alphagov/govuk-frontend#1059
davidhunter08 added a commit that referenced this issue Nov 22, 2018
@davidhunter08
[refs #206] Button padding
95ee06a 
Increased button padding on desktop.
chrimesdev added a commit that referenced this issue Nov 22, 2018
@chrimesdev
[refs #206] Use chevron icon for the back link
a5235e0 
Instead of using the arrow-shape mixin to generate an icon, use the
NHS chevron SVG icon.
chrimesdev added a commit that referenced this issue Nov 27, 2018
@chrimesdev
[refs #206] remove incorrect color from the back link
71b8812
chrimesdev added a commit that referenced this issue Nov 27, 2018
@chrimesdev
[refs #206] remove incorrect color from the back link
c036dad
chrimesdev added a commit that referenced this issue Nov 27, 2018
@chrimesdev
[refs #206] remove incorrect color from the back link
7b0a408
mcheung-nhs added a commit that referenced this issue Nov 27, 2018
@mcheung-nhs
[refs #206] Header updates
4b79274 
Minor formatting to the files
Nunjucks updates
Add extra example with logo only
Readme updates
mcheung-nhs added a commit that referenced this issue Nov 27, 2018
@mcheung-nhs
[refs #206] Update Nunjucks template
181a202 
Add homeHref Nunjucks parameter
Correct close div nesting issue. Will be refactored to make code
easier to read.
chrimesdev added a commit that referenced this issue Dec 3, 2018
@chrimesdev
[refs #206] Document the form element changes
efbf70a
chrimesdev added a commit that referenced this issue Dec 3, 2018
@chrimesdev
[refs #206] Document the form element changes
d46957d
chrimesdev added a commit that referenced this issue Dec 3, 2018
@chrimesdev
[refs #206] Document the form element changes
7734928
chrimesdev added a commit that referenced this issue Dec 3, 2018
@chrimesdev
[refs #206] Document the form element changes
13ac90a
chrimesdev added a commit that referenced this issue Dec 3, 2018
@chrimesdev
[refs #206] Document the form element changes
bad562b
chrimesdev added a commit that referenced this issue Dec 3, 2018
@chrimesdev
[refs #206] Document the form element changes
e575ba4
chrimesdev added a commit that referenced this issue Dec 3, 2018
@chrimesdev
[refs #206] Document the form element changes
7f7c1ed
chrimesdev added a commit that referenced this issue Dec 3, 2018
@chrimesdev
[refs #206] Update the footer NHS logo example
bd8489e 
The Footer example was using the incorrect NHS logo.
chrimesdev added a commit that referenced this issue Dec 3, 2018
@chrimesdev
[refs #206] Update the footer NHS logo example
72d3a9a 
The Footer example was using the incorrect NHS logo.
chrimesdev added a commit that referenced this issue Dec 3, 2018
@chrimesdev
Merge pull request #272 from nhsuk/refactor/footer-logo
fe21844 
[refs #206] Update the footer NHS logo example
chrimesdev added a commit that referenced this issue Dec 3, 2018
@chrimesdev
[refs #206] Fix incorrect back link and error summary examples
fb0b541 
The HTML markup for the back link and error summary were wrong,
they have been updated to reflect the correct markup.
davidhunter08 pushed a commit that referenced this issue Dec 3, 2018
@chrimesdev @davidhunter08
[refs #206] Fix incorrect back link and error summary examples
b46db8b 
The HTML markup for the back link and error summary were wrong,
they have been updated to reflect the correct markup.
davidhunter08 added a commit that referenced this issue Dec 3, 2018
@davidhunter08
Merge pull request #273 from nhsuk/refactor/form-examples
4d1ae65 
[refs #206] Fix incorrect back link and error summary examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrimesdev chrimesdev

@davidhunter08 davidhunter08

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrimesdev @davidhunter08