Pass alpaka_ENABLE_WERROR from environment to CMake
#2107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimeonEhrig
previously approved these changes
Aug 30, 2023
|
The change looks good. But no test job passed. I believe there is a lot to do 😬 |
This was referenced Aug 30, 2023
j-stephan
force-pushed
the
enable_werror
branch
from
57a8dbe to
17256ac
Compare
This was referenced Sep 2, 2023
Merged
j-stephan
force-pushed
the
enable_werror
branch
from
17256ac to
45a7f7c
Compare
This was referenced Sep 5, 2023
j-stephan
force-pushed
the
enable_werror
branch
from
45a7f7c to
77a279c
Compare
j-stephan
force-pushed
the
enable_werror
branch
from
77a279c to
01d980b
Compare
j-stephan
commented
Sep 11, 2023
| @@ -10,7 +10,6 @@ if(alpaka_ACC_GPU_CUDA_ENABLE AND (CMAKE_CUDA_COMPILER_ID STREQUAL "NVIDIA")) | |||
| if(alpaka_ENABLE_WERROR) | |||
| list(APPEND alpaka_DEV_COMPILE_OPTIONS "$<$<COMPILE_LANGUAGE:CUDA>:SHELL:--Wreorder>") | |||
| list(APPEND alpaka_DEV_COMPILE_OPTIONS "$<$<COMPILE_LANGUAGE:CUDA>:SHELL:--Wdefault-stream-launch>") | |||
| list(APPEND alpaka_DEV_COMPILE_OPTIONS "$<$<COMPILE_LANGUAGE:CUDA>:SHELL:--Wmissing-launch-bounds>") | |||
There was a problem hiding this comment.
I removed this warning since it warns about an optional CUDA feature (enforcing a compile-time grid / block size) we do not make use of.
This was referenced Sep 12, 2023
Merged
j-stephan
force-pushed
the
enable_werror
branch
from
01d980b to
3cbb037
Compare
j-stephan
force-pushed
the
enable_werror
branch
from
3cbb037 to
5d29547
Compare
|
Since so many warnings occur in the code generated by nvcc, I wonder why we need to enable |
|
The changeset of this PR is also included in #2163. If that PR gets merged, this PR becomes obsolete. |
|
Superseded by #2163. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1977 I forgot to ensure that
alpaka_ENABLE_WERRORis also passed to CMake in the generation step. This PR fixes this oversight.