Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize CMake #1977

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Conversation

j-stephan
Copy link
Member

This PR is a small convenience update for our CMake build system (mostly for the tests). Notable changes:

  • rand/Traits.hpp was missing the <cstdint> include which led to a build error on my system.
  • -Werror is no longer enabled by default when BUILD_TESTING is set to ON. If desired users can set alpaka_ENABLE_WERROR to compile with -Werror; this is also done in the CI. Fixes Cmake switch for -Werror #958.
  • In Debug mode nvcc will now make use of the-G flag (device-side debug information) which CMake doesn't enable by default. Fixes RelWithDebInfo & CUDA -G #1060.
  • In Debug mode gcc will use the -Og optimization level.
  • In Debug mode clang, AppleClang and icpx will use the -O0 optimization level.
  • In Debug mode MSVC will use the /Od optimization level.
  • Fixed a few minor CMake bugs and typos I found along the way.

cmake/alpakaCommon.cmake Outdated Show resolved Hide resolved
test/common/devCompileOptions.cmake Outdated Show resolved Hide resolved
SimeonEhrig
SimeonEhrig previously approved these changes Jul 24, 2023
bernhardmgruber
bernhardmgruber previously approved these changes Aug 2, 2023
README.md Outdated Show resolved Hide resolved
@bernhardmgruber bernhardmgruber merged commit 388483c into alpaka-group:develop Aug 3, 2023
@j-stephan j-stephan deleted the cmake_werror branch August 3, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RelWithDebInfo & CUDA -G Cmake switch for -Werror
3 participants