Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename extentBuf, extentView and offsetView #2144

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

j-stephan
Copy link
Member

This PR renames a few variables inside ViewSubViewTest.cpp and ViewPlainPtrTest.cpp:

  • extentBuf becomes bufExtent
  • extentView becomes viewExtent
  • offsetView becomes viewOffset

This is done to fix the following MSVC warning which breaks in #2107:

D:\a\alpaka\alpaka\test\unit\mem\view\src\ViewPlainPtrTest.cpp(37,20): warning C4459: declaration of 'extentBuf' hides global declaration [D:\a\alpaka\alpaka\build\test\unit\mem\view\memViewTest.vcxproj]

I renamed extentView and offsetView to keep the naming inside the affected functions consistent.

@j-stephan j-stephan merged commit 3208419 into alpaka-group:develop Sep 6, 2023
@j-stephan j-stephan deleted the C4459 branch September 6, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants