[Unauth Home page] Sort Explore Spaces section on most activity

[hero101]

• Uses the exploreSpaces query to show on the Home page for unauthenticated users

Depends on alkem-io/server#4578

Summary by CodeRabbit

• New Features

  • Introduced a new search functionality for exploring spaces.
  • Streamlined access to space data without pagination.

• Bug Fixes

  • Simplified data fetching logic for the ExploreSpacesUnauthenticatedContainer component.

• Refactor

  • Removed unnecessary complexity related to pagination in space queries.
  • Increased the item display limit from 14 to 15 in the layout.

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)

• src/core/apollo/generated/apollo-hooks.ts is excluded by !**/generated/**
• src/core/apollo/generated/graphql-schema.ts is excluded by !**/generated/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes in this pull request involve modifications to the GraphQL queries and the ExploreSpacesUnauthenticatedContainer component. A new query, ExploreSpacesSearch, is introduced to facilitate space searching, while the existing ExploreAllSpaces query is simplified by removing pagination and filtering parameters. The ExploreSpacesUnauthenticatedContainer component has been updated to use the new querying logic, eliminating the previous pagination logic and adjusting data handling accordingly. Additionally, the ExploreSpacesUnauthenticatedView component has minor layout adjustments.

Changes

File	Change Summary
src/main/topLevelPages/myDashboard/ExploreSpaces/ExploreSpaces.graphql	- Added: query ExploreSpacesSearch($searchData: SearchInput!) - Modified: query ExploreAllSpaces (removed parameters) - Unchanged: query WelcomeSpace - Unchanged: fragment ExploreSpaces - Added: fragment ExploreSpacesSearch on SearchResultSpace
src/main/topLevelPages/myDashboard/ExploreSpaces/ExploreSpacesUnauthenticatedContainer.tsx	- Updated: ExploreSpacesUnauthenticatedContainer (removed pagination logic, simplified data fetching) - Updated: ExploreSpacesContainerEntities (data structure change)
src/main/topLevelPages/myDashboard/ExploreSpaces/ExploreSpacesUnauthenticatedView.tsx	- Updated: ITEMS_LIMIT constant (increased from 14 to 15) - Modified layout with sx={{ flexWrap: 'wrap' }} on Gutters component

Possibly related PRs

• New Explore view for unauthenticated users #6945: This PR introduces a new Explore view for unauthenticated users and modifies the GraphQL queries related to exploring spaces, which aligns with the changes made in the main PR regarding the ExploreSpacesSearch and ExploreAllSpaces queries.
• Explore spaces - no members filter for not authenticated, no text on top #6871: This PR modifies the functionality of the "Explore spaces" feature for unauthenticated users, which is relevant as it relates to the overall user experience in exploring spaces, similar to the changes in the main PR that streamline querying spaces.

Suggested reviewers

• ccano

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 3

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 480baad and b5ff36f.

⛔ Files ignored due to path filters (3)

• src/core/apollo/generated/apollo-helpers.ts is excluded by !**/generated/**
• src/core/apollo/generated/apollo-hooks.ts is excluded by !**/generated/**
• src/core/apollo/generated/graphql-schema.ts is excluded by !**/generated/**

📒 Files selected for processing (2)

• src/main/topLevelPages/myDashboard/ExploreSpaces/ExploreSpaces.graphql (1 hunks)
• src/main/topLevelPages/myDashboard/ExploreSpaces/ExploreSpacesUnauthenticatedContainer.tsx (5 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

src/main/topLevelPages/myDashboard/ExploreSpaces/ExploreSpaces.graphql (1)

Pattern src/**/*.{graphql,gql}: Review the GraphQL schema and queries for best practices, potential bugs, and adherence to the project's GraphQL standards.
Ensure that the schema is well-defined and queries are optimized.
Check for security vulnerabilities.

src/main/topLevelPages/myDashboard/ExploreSpaces/ExploreSpacesUnauthenticatedContainer.tsx (1)

Pattern src/**/*.{ts,tsx,js}: Review the React.js/TypeScript/JavaScript code for best practices and potential bugs.
Ensure that the code adheres to TypeScript's typing system and modern standards.
Ensure sufficient error handling and logging is present.
Check for common security vulnerabilities such as:

• SQL Injection
• XSS (Cross-Site Scripting)
• CSRF (Cross-Site Request Forgery)
• Insecure dependencies
• Sensitive data exposure

🔇 Additional comments (3)

src/main/topLevelPages/myDashboard/ExploreSpaces/ExploreSpacesUnauthenticatedContainer.tsx (3)

10-10: LGTM: New import added correctly

The new import for SpacesExplorerMembershipFilter and SpaceWithParent has been added correctly. This change aligns with the modifications in the component's logic and type usage.

---

46-46: LGTM: Simplified skip condition

The skip condition for useWelcomeSpaceQuery has been simplified to directly use shouldSearch. This change improves readability and aligns with the component's updated logic.

---

Line range hint 77-91: Consider performance implications and add error handling

The replacement of usePaginatedQuery with useExploreAllSpacesQuery simplifies the code but may have performance implications:

1. Fetching all spaces at once could be inefficient for large datasets.
2. There's no error handling for the new query.

Consider the following improvements:

1. Evaluate if fetching all spaces at once is suitable for your use case.
2. Add error handling for the useExploreAllSpacesQuery.
3. Implement proper loading state management.

Example error handling:

const { data: spacesData, loading: isLoadingSpaces, error: spacesError } = useExploreAllSpacesQuery();

if (spacesError) {
  // Handle error (e.g., show error message)
}

To verify the impact of this change, please run the following command to check the number of spaces typically returned:

[bobbykolev]

Looks good, also tested locally, thanks @hero101