Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance] Lazy loading of most top routes #7112

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

bobbykolev
Copy link
Contributor

@bobbykolev bobbykolev commented Oct 29, 2024

This PR aims to speed up the Homepage (not only).

With the simple change of loading dynamically all top-level routes, now the main bundle size is significantly reduced (~40%):

@SimoneZaza approved the changes, but we could revert some of the dynamic imports (the space one) in the future.

image
image

In this PR the following page was deleted:
https://alkem.io/about

Summary by CodeRabbit

  • New Features

    • Introduced lazy loading for various routes, enhancing performance and user experience by reducing initial load times.
  • Bug Fixes

    • Removed the About page, streamlining the application interface.
  • Refactor

    • Changed export statements for multiple components from named to default exports, improving import consistency.
  • Chores

    • Updated routing structure to include Suspense for better loading state management.

Copy link

coderabbitai bot commented Oct 29, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request includes modifications to several components related to routing in a React application. Key changes involve altering export statements from named exports to default exports for the SpaceRoute, AdminRoute, and SpaceExplorerPage components. Additionally, the TopLevelRoutes component has been updated to implement lazy loading for various routes, improving the loading experience. The AboutPage component has been removed entirely, streamlining the routing structure.

Changes

File Path Change Summary
src/domain/journey/space/routing/SpaceRoute.tsx Changed export from named to default for SpaceRoute.
src/domain/platform/admin/routing/AdminRoute.tsx Changed export from named to default for AdminRoute.
src/main/routing/TopLevelRoutes.tsx Updated to use lazy loading for multiple routes and changed component signature from FC to function. Removed AboutPage import.
src/main/topLevelPages/About.tsx Removed the AboutPage component entirely.
src/main/topLevelPages/topLevelSpaces/SpaceExplorerPage.tsx Changed export from named to default for SpaceExplorerPage.

Possibly related PRs

  • New Explore view for unauthenticated users #6945: The changes in this PR involve modifying the export statement of the JourneyTile component, which is related to the SpaceRoute component's export changes in the main PR.
  • [Simple Homepage] Explore spaces  #7097: This PR introduces a new columns prop to the JourneyTile component, which is relevant to the changes made in the SpaceRoute component as both are part of the journey and space exploration features.

Suggested labels

client

Suggested reviewers

  • bobbykolev

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@bobbykolev bobbykolev changed the base branch from simple-homepage to client-7033-menu October 29, 2024 15:55
@bobbykolev bobbykolev changed the title Lazy loading of most top routes [Performance] Lazy loading of most top routes Oct 30, 2024
Base automatically changed from client-7033-menu to simple-homepage October 31, 2024 09:03
@bobbykolev bobbykolev requested a review from ccanos November 1, 2024 10:36
@bobbykolev bobbykolev marked this pull request as ready for review November 1, 2024 10:36
Copy link

coderabbitai bot commented Nov 4, 2024

@reactoholic: I will review the changes.

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@reactoholic
Copy link
Contributor

@coderabbitai review

Copy link

coderabbitai bot commented Nov 4, 2024

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@reactoholic reactoholic merged commit d476e48 into simple-homepage Nov 4, 2024
3 checks passed
@reactoholic reactoholic deleted the lazy-loading-top-routes branch November 4, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants