-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boxes: Add support for Boxes #348
Conversation
…-sdk into feature/box-storage
* starting to add box support * Add boxes to atc * Format files with black * Add boxes docstring * Add boxes support for appl creation * Update cucumber steps for appl txn encoding for boxes * Formatting * Point testing branch to box-reference (WIP) * Sort imports on relevant files and format * Add translation for foreign apps in box refs and some local unit tests * Add some invalid cases for box translation * Check for None when iterating box refs * Add self app id references and tests * Minor changes for box support * Split boxref to separate file * Change box name type to bytes * Change docs references from box string to bytes * Refactor cucumber steps * Refactoring code and adding docstrings * Add another comment * Change test steps to encode box args like app args * Add safety checks for box references * Add some detailed errors and refactor * Format unit test * Fix foreign index error and revise undictify method * Finish merging cucumber steps * Formatting * Fix box tests again * Encoded as bytes unit test (#344) * Unit test for encoding.py's `encode_as_bytes()` * Accept AttributeError for foreign apps array if it is referencing its own app id * Add unit test for empty foreign app array * Change unit test to pass in None foreign array * Change undictify method for boxes * Formatting * Change test branch * Change type hints for atc boxes * Check for int type for box reference id * Change type ignore annotation Co-authored-by: Ben Guidarelli <[email protected]> Co-authored-by: Zeph Grunschlag <[email protected]>
* starting to add box support * Add boxes to atc * Format files with black * Add boxes docstring * Add boxes support for appl creation * Update cucumber steps for appl txn encoding for boxes * Formatting * Point testing branch to box-reference (WIP) * Sort imports on relevant files and format * Add translation for foreign apps in box refs and some local unit tests * Add some invalid cases for box translation * Check for None when iterating box refs * Add self app id references and tests * Minor changes for box support * Split boxref to separate file * Change box name type to bytes * Change docs references from box string to bytes * Refactor cucumber steps * Refactoring code and adding docstrings * Add another comment * Change test steps to encode box args like app args * Add safety checks for box references * Add some detailed errors and refactor * Format unit test * Fix foreign index error and revise undictify method * Finish merging cucumber steps * Formatting * Fix box tests again * Encoded as bytes unit test (#344) * Unit test for encoding.py's `encode_as_bytes()` * Accept AttributeError for foreign apps array if it is referencing its own app id * Add unit test for empty foreign app array * Change unit test to pass in None foreign array * Change undictify method for boxes * Formatting * Change test branch * Change type hints for atc boxes * Add algod endpoint for getting app box by name * Add steps test for box application path * Escape forward slashes in uri * Formatting * Finish merging * Add box integration tests * Formatting * Add boxes integration test tag to makefile * Change step prefix * Revert step prefix * Change algod request for box search and test * Change makefile test * Formatting * Remove unused line * Change wording around box encoding steps * Try running feature branch tests Co-authored-by: Ben Guidarelli <[email protected]> Co-authored-by: Zeph Grunschlag <[email protected]>
* Add GetApplicationBoxes API and add steps * Temporarily set to list-boxes branch in SDK testing * Conform to new response format in boxes API * Change test branch * Add max params to boxes endpoint * Fix paths for empty queries * Change steps to check for query params in boxes request * Formatting * Reset test branch * Remove redundant part in cucumber step * Minor refactoring for set equality * Revert "Minor refactoring for set equality" This reverts commit 0a2b0d7. * Check list length first, then do set comparison after * Revert test branch * Fix branch name
* Merge develop into feature/boxes * Change testing branch
* add check to desc so we dont output null if undefined (#368) * Bumped version to v1.16.1 * Enhancement: Trim the indexer images and use the sandbox instead of custom dockers (#367) Co-authored-by: algochoi <[email protected]> Co-authored-by: Michael Diamant <[email protected]> * Bug-fix: Pass verbosity through to testing harness (#373) * Enhancement: Add State Proof support (#370) * add stateproof support * Enhancement: Deprecating use of langspec (#371) * Bumped version to v1.17.0 * Update README.md Co-authored-by: Zeph Grunschlag <[email protected]> * Mergeback: Release v1.17.0b1 (#378) * Bumped version * Update README.md * bumped version to v1.17.0 Co-authored-by: Ben Guidarelli <[email protected]> Co-authored-by: Barbara Poon <[email protected]> Co-authored-by: Zeph Grunschlag <[email protected]> Co-authored-by: algochoi <[email protected]> Co-authored-by: Michael Diamant <[email protected]> Co-authored-by: shiqizng <[email protected]> Co-authored-by: Jack Smith <[email protected]> Co-authored-by: Jack <[email protected]> Co-authored-by: Lucky Baar <[email protected]>
* Add path tests for Indexer boxes * Add next page param in indexer api * Formatting * Modify step to add next token in indexer boxes test * Update algosdk/v2client/indexer.py Co-authored-by: Zeph Grunschlag <[email protected]> * Update .test-env Co-authored-by: Hang Su <[email protected]> Co-authored-by: Hang Su <[email protected]> Co-authored-by: Zeph Grunschlag <[email protected]>
* add indexer impl in sdk * merge step for indexer * add indexer confirmed steps * add indexer confirmed steps * add indexer confirmed steps * minor * change to ms sleep * per new step expectation * unify with applications.boxes * phrasing * Update .test-env * Update tests/steps/application_v2_steps.py Co-authored-by: algochoi <[email protected]> * Update tests/steps/application_v2_steps.py Co-authored-by: algochoi <[email protected]> * merge sleep steps Co-authored-by: algochoi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions, including more line items to the CHANGELOG.md
Co-authored-by: Zeph Grunschlag <[email protected]>
…algorand-sdk into feature/box-storage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as the only remaining discussion is around the CHANGELOG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my approval left for the part I didn't write, i.e. mostly outside tests
Co-authored-by: Hang Su <[email protected]>
Adds SDK support for Boxes introduced in algorand/indexer#1168 and algorand/go-algorand#4149.