Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Boxes Indexer Integration test #382

Merged
merged 15 commits into from
Sep 14, 2022
Merged

Enhancement: Boxes Indexer Integration test #382

merged 15 commits into from
Sep 14, 2022

Conversation

ahangsu
Copy link
Contributor

@ahangsu ahangsu commented Sep 7, 2022

No description provided.

@ahangsu ahangsu force-pushed the ahangsu/indexer-integration-boxes branch 2 times, most recently from a357521 to 8538701 Compare September 8, 2022 17:35
@ahangsu ahangsu mentioned this pull request Sep 8, 2022
Closed
@ahangsu ahangsu force-pushed the ahangsu/indexer-integration-boxes branch from 8538701 to d1c9b1a Compare September 8, 2022 19:14
ahangsu
ahangsu commented Sep 8, 2022
View reviewed changes
.test-env Outdated Show resolved Hide resolved
@ahangsu ahangsu force-pushed the ahangsu/indexer-integration-boxes branch 2 times, most recently from ae14d9a to 11dc4bb Compare September 9, 2022 19:22
@ahangsu ahangsu force-pushed the ahangsu/indexer-integration-boxes branch from 11dc4bb to ce374b8 Compare September 9, 2022 19:40
@ahangsu ahangsu marked this pull request as ready for review September 9, 2022 19:55
@ahangsu ahangsu force-pushed the ahangsu/indexer-integration-boxes branch 3 times, most recently from 48ff94d to aff3e6a Compare September 13, 2022 16:42
@ahangsu ahangsu force-pushed the ahangsu/indexer-integration-boxes branch from aff3e6a to b517f1d Compare September 13, 2022 17:01
@ahangsu ahangsu requested review from tzaffi, algochoi and michaeldiamant and removed request for tzaffi September 13, 2022 18:19
tzaffi
tzaffi reviewed Sep 13, 2022
View reviewed changes
tests/steps/other_v2_steps.py
@@ -1023,6 +1023,12 @@ def algod_v2_client(context):
context.app_acl = algod.AlgodClient(daemon_token, algod_address)


@given("an indexer v2 client")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👶 - indexer is reborn!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: might be nice to put right next to where algod is defined.

tzaffi
tzaffi reviewed Sep 13, 2022
View reviewed changes
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very tempted to approve, but put up some small nits worth discussing.

tzaffi
tzaffi approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@tzaffi tzaffi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

algochoi
algochoi reviewed Sep 14, 2022
View reviewed changes
Copy link
Contributor

@algochoi algochoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor formatting comments, looks good!

Non-urgent thought but I wonder if long term we aim to write indexer integration tests for all existing features and we want to split the indexer functionality into another file.

tests/steps/application_v2_steps.py Outdated Show resolved Hide resolved
tests/steps/steps.py Show resolved Hide resolved
tests/steps/application_v2_steps.py Outdated Show resolved Hide resolved
tests/steps/application_v2_steps.py Outdated Show resolved Hide resolved
@ahangsu ahangsu force-pushed the ahangsu/indexer-integration-boxes branch from 3f4dd69 to cb70c71 Compare September 14, 2022 19:05
algochoi
algochoi reviewed Sep 14, 2022
View reviewed changes
tests/steps/application_v2_steps.py Outdated Show resolved Hide resolved
tests/steps/application_v2_steps.py Outdated Show resolved Hide resolved
tests/steps/steps.py Show resolved Hide resolved
@ahangsu ahangsu force-pushed the ahangsu/indexer-integration-boxes branch from 908b7f7 to ab55587 Compare September 14, 2022 19:33
algochoi
algochoi reviewed Sep 14, 2022
View reviewed changes
tests/steps/application_v2_steps.py
@@ -415,14 +419,19 @@ def remember_app_id(context):
context.app_ids.append(app_id)


def wait_for_algod_transaction_processing_to_complete():
@then(
"I sleep for {millisecond_num} milliseconds for indexer to digest things down."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ahangsu ahangsu merged commit ef8be90 into feature/box-storage Sep 14, 2022
@ahangsu ahangsu deleted the ahangsu/indexer-integration-boxes branch September 14, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzaffi tzaffi tzaffi approved these changes

@algochoi algochoi algochoi approved these changes

@michaeldiamant michaeldiamant Awaiting requested review from michaeldiamant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahangsu @tzaffi @algochoi