-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Algod endpoint for GetApplicationBoxByName #346
Conversation
* Unit test for encoding.py's `encode_as_bytes()`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@algochoi Thanks for your efforts here + taking questions via live discussion. ☕
Friendly reminder that the branch reference in run_integration.sh
requires a change after merging algorand/go-algorand#4183.
Up to you if you prefer merging as is + updating later or holding open until upstream PR merges.
Thanks for the quick feedback:
Per our discussion, I'll merge into the feature branch and leave comments on the parent PR: #348 I think the integration tests will fail until we also merge in the Algod |
This PR adds API endpoints for GetApplicationBoxByName, and implements cucumber tests for the path names and integration tests for reading boxes from algod.
Path-related tests: algorand/algorand-sdk-testing#187
Integration tests: algorand/algorand-sdk-testing#196
Related to Algod Box API ticket here: algorand/go-algorand#3973