Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Algod endpoint for GetApplicationBoxByName #346

Merged
merged 55 commits into from
Jun 30, 2022

Conversation

algochoi
Copy link
Contributor

@algochoi algochoi commented Jun 10, 2022

This PR adds API endpoints for GetApplicationBoxByName, and implements cucumber tests for the path names and integration tests for reading boxes from algod.

Path-related tests: algorand/algorand-sdk-testing#187

Integration tests: algorand/algorand-sdk-testing#196

Related to Algod Box API ticket here: algorand/go-algorand#3973

@algochoi algochoi marked this pull request as ready for review June 23, 2022 19:13
Copy link
Contributor

@michaeldiamant michaeldiamant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@algochoi Thanks for your efforts here + taking questions via live discussion. ☕

Friendly reminder that the branch reference in run_integration.sh requires a change after merging algorand/go-algorand#4183.

Up to you if you prefer merging as is + updating later or holding open until upstream PR merges.

@algochoi
Copy link
Contributor Author

algochoi commented Jun 30, 2022

Thanks for the quick feedback:

Friendly reminder that the branch reference in run_integration.sh requires a change after merging algorand/go-algorand#4183. Up to you if you prefer merging as is + updating later or holding open until upstream PR merges.

Per our discussion, I'll merge into the feature branch and leave comments on the parent PR: #348

I think the integration tests will fail until we also merge in the Algod box API changes as well. algorand/go-algorand#4183

@algochoi algochoi merged commit 256dc72 into feature/box-storage Jun 30, 2022
@algochoi algochoi deleted the box-api-paths branch June 30, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants