Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Slack Notifications via Webhook #1522

Merged
merged 8 commits into from
Jun 25, 2024
Merged

Add Support for Slack Notifications via Webhook #1522

merged 8 commits into from
Jun 25, 2024

Conversation

svenvg93
Copy link
Contributor

πŸ“ƒ Description

This PR adds support for Slack notifications. As it was listed here #40
It been tested with Slack Apps and Legacy Webhooks

πŸͺ΅ Changelog

βž• Added

  • Slack Notifications

πŸ“· Screenshots

Slack App
SchermΒ­afbeelding 2024-06-11 om 22 15 38

Legacy Webhooks
image

@svenvg93 svenvg93 requested a review from alexjustesen as a code owner June 11, 2024 20:23
@alexjustesen alexjustesen added the πŸŽ‰ feature New feature or request label Jun 13, 2024
@alexjustesen alexjustesen added this to the v0.x.0 (notifications) milestone Jun 13, 2024
@alexjustesen alexjustesen changed the base branch from main to 0.21.0 June 13, 2024 00:33
@alexjustesen
Copy link
Owner

I'm going to circle back around to this PR early next week, leaving myself https://laravel.com/docs/11.x/notifications#slack-notifications for consideration on whether we should "just" support Slack Apps.

@alexjustesen alexjustesen changed the base branch from 0.21.0 to main June 24, 2024 21:24
@alexjustesen alexjustesen changed the base branch from main to develop-0.21.0 June 24, 2024 21:25
@alexjustesen alexjustesen changed the title Add Support for Slack Notifications Add Support for Slack Notifications via Webhook Jun 24, 2024
@alexjustesen
Copy link
Owner

@svenvg93 when ya got a chance can you resolve conflicts?

@svenvg93
Copy link
Contributor Author

svenvg93 commented Jun 25, 2024

@svenvg93 when ya got a chance can you resolve conflicts?

Done, should be all good now. I hope πŸ˜…
Kinda was afraid this would happen, will do the same for the heathcheck pr when this one is merged into the branch

@alexjustesen alexjustesen merged commit 9704676 into alexjustesen:develop-0.21.0 Jun 25, 2024
1 check passed
@alexjustesen alexjustesen mentioned this pull request Jun 25, 2024
12 tasks
@svenvg93 svenvg93 deleted the add-slack branch June 25, 2024 17:04
alexjustesen added a commit that referenced this pull request Aug 8, 2024
* Add Placeholder text for notifications (#1570)

first_commit

* Add Gotify Notifications via Webhook (#1561)

* first_commit

* Ready!

* Add_placeholder

* change url

---------

Co-authored-by: Alex Justesen <[email protected]>

* Add Support for Slack Notifications via Webhook (#1522)

* First Commit

* Fix lint

* add_url_placeholder

* Fix the liniting

* Add HealthCheck.io Notifications via Webhooks (#1567)

* first_commit

* linting

* add_descrip_for_threshold

* Change name

* add_url_placeholder

* fix_linting

* Add Pushover Notifications via Webhooks (#1574)

* add_pushover

* add_placeholder

* Linting

---------

Co-authored-by: Alex Justesen <[email protected]>

* Add ntfy Notifications via Webhooks (#1579)

* first_push

* Fix_json_payload

* Add_auth_option

* fix lint

* fix packet_loss_%

* added eof line

---------

Co-authored-by: Alex Justesen <[email protected]>

* Add Ookla URL to the notification (#1615)

* first commit

* added eof line

---------

Co-authored-by: Alex Justesen <[email protected]>

* Fix notifications layouts (#1639)

first commit

---------

Co-authored-by: Sven van Ginkel <[email protected]>
alexjustesen added a commit that referenced this pull request Aug 8, 2024
* Develop v0.21.0 (additional notification channels) (#1647)

* Add Placeholder text for notifications (#1570)

first_commit

* Add Gotify Notifications via Webhook (#1561)

* first_commit

* Ready!

* Add_placeholder

* change url

---------

Co-authored-by: Alex Justesen <[email protected]>

* Add Support for Slack Notifications via Webhook (#1522)

* First Commit

* Fix lint

* add_url_placeholder

* Fix the liniting

* Add HealthCheck.io Notifications via Webhooks (#1567)

* first_commit

* linting

* add_descrip_for_threshold

* Change name

* add_url_placeholder

* fix_linting

* Add Pushover Notifications via Webhooks (#1574)

* add_pushover

* add_placeholder

* Linting

---------

Co-authored-by: Alex Justesen <[email protected]>

* Add ntfy Notifications via Webhooks (#1579)

* first_push

* Fix_json_payload

* Add_auth_option

* fix lint

* fix packet_loss_%

* added eof line

---------

Co-authored-by: Alex Justesen <[email protected]>

* Add Ookla URL to the notification (#1615)

* first commit

* added eof line

---------

Co-authored-by: Alex Justesen <[email protected]>

* Fix notifications layouts (#1639)

first commit

---------

Co-authored-by: Sven van Ginkel <[email protected]>

* updated npm dependencies

---------

Co-authored-by: Sven van Ginkel <[email protected]>
@DoctorT07
Copy link

he doent work for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸŽ‰ feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants