Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Placeholder text for notifications #1570

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Add Placeholder text for notifications #1570

merged 2 commits into from
Jun 24, 2024

Conversation

svenvg93
Copy link
Contributor

📃 Description

This PR adds a placeholder text for the notification endpoint. To five the user an idea what the giving url/id should look like.

@svenvg93 svenvg93 marked this pull request as ready for review June 24, 2024 22:46
@svenvg93 svenvg93 requested a review from alexjustesen as a code owner June 24, 2024 22:46
@alexjustesen alexjustesen merged commit a25a838 into alexjustesen:develop-0.21.0 Jun 24, 2024
1 check passed
@svenvg93 svenvg93 deleted the add-url-placeholders branch June 25, 2024 05:32
alexjustesen added a commit that referenced this pull request Aug 8, 2024
* Add Placeholder text for notifications (#1570)

first_commit

* Add Gotify Notifications via Webhook (#1561)

* first_commit

* Ready!

* Add_placeholder

* change url

---------

Co-authored-by: Alex Justesen <[email protected]>

* Add Support for Slack Notifications via Webhook (#1522)

* First Commit

* Fix lint

* add_url_placeholder

* Fix the liniting

* Add HealthCheck.io Notifications via Webhooks (#1567)

* first_commit

* linting

* add_descrip_for_threshold

* Change name

* add_url_placeholder

* fix_linting

* Add Pushover Notifications via Webhooks (#1574)

* add_pushover

* add_placeholder

* Linting

---------

Co-authored-by: Alex Justesen <[email protected]>

* Add ntfy Notifications via Webhooks (#1579)

* first_push

* Fix_json_payload

* Add_auth_option

* fix lint

* fix packet_loss_%

* added eof line

---------

Co-authored-by: Alex Justesen <[email protected]>

* Add Ookla URL to the notification (#1615)

* first commit

* added eof line

---------

Co-authored-by: Alex Justesen <[email protected]>

* Fix notifications layouts (#1639)

first commit

---------

Co-authored-by: Sven van Ginkel <[email protected]>
alexjustesen added a commit that referenced this pull request Aug 8, 2024
* Develop v0.21.0 (additional notification channels) (#1647)

* Add Placeholder text for notifications (#1570)

first_commit

* Add Gotify Notifications via Webhook (#1561)

* first_commit

* Ready!

* Add_placeholder

* change url

---------

Co-authored-by: Alex Justesen <[email protected]>

* Add Support for Slack Notifications via Webhook (#1522)

* First Commit

* Fix lint

* add_url_placeholder

* Fix the liniting

* Add HealthCheck.io Notifications via Webhooks (#1567)

* first_commit

* linting

* add_descrip_for_threshold

* Change name

* add_url_placeholder

* fix_linting

* Add Pushover Notifications via Webhooks (#1574)

* add_pushover

* add_placeholder

* Linting

---------

Co-authored-by: Alex Justesen <[email protected]>

* Add ntfy Notifications via Webhooks (#1579)

* first_push

* Fix_json_payload

* Add_auth_option

* fix lint

* fix packet_loss_%

* added eof line

---------

Co-authored-by: Alex Justesen <[email protected]>

* Add Ookla URL to the notification (#1615)

* first commit

* added eof line

---------

Co-authored-by: Alex Justesen <[email protected]>

* Fix notifications layouts (#1639)

first commit

---------

Co-authored-by: Sven van Ginkel <[email protected]>

* updated npm dependencies

---------

Co-authored-by: Sven van Ginkel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants