Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HealthCheck.io Notifications via Webhooks #1567

Merged
merged 10 commits into from
Jul 18, 2024
Merged

Add HealthCheck.io Notifications via Webhooks #1567

merged 10 commits into from
Jul 18, 2024

Conversation

svenvg93
Copy link
Contributor

📃 Description

To close #1556

Add support for Healthcheck.io notifications.

🪵 Changelog

➕ Added

  • Add Healthcheck.io to the notification page
  • Add /fail to the url for Threshold notifications
  • Add helperText to the Threshold toggle to inform user it will be sent the /fail path
  • Add heathcheck.io to the settings migration

📷 Screenshots

Settings page
Scherm­afbeelding 2024-06-23 om 21 46 20

Healthcheck.io Completed test:
Scherm­afbeelding 2024-06-22 om 17 11 42

Healthcheck.io Threshold breach
Scherm­afbeelding 2024-06-22 om 17 12 20

@svenvg93 svenvg93 marked this pull request as ready for review June 23, 2024 20:08
@svenvg93 svenvg93 requested a review from alexjustesen as a code owner June 23, 2024 20:08
@svenvg93 svenvg93 marked this pull request as draft June 24, 2024 10:31
@alexjustesen alexjustesen changed the base branch from main to develop-0.21.0 June 24, 2024 21:25
@alexjustesen
Copy link
Owner

Thanks for all the work on notification channels! Just a heads up I'm pointing the PRs at develop-0.21.0 so we can collect them all for the next release.

@svenvg93
Copy link
Contributor Author

@alexjustesen do you how to make sure the threshold notification is sent after the completed one.

Now the completed comes after the threshold which makes healthcheck not sent the mail to the user.

@svenvg93 svenvg93 changed the title Add HealthCheck.io Notifications Add HealthCheck.io Notifications via Webhooks Jun 25, 2024
@svenvg93
Copy link
Contributor Author

svenvg93 commented Jun 25, 2024 •
edited
Loading

Cant find a way to make sure the threshold will be sent as last, so lets go!

@svenvg93 svenvg93 marked this pull request as ready for review June 25, 2024 17:07
@svenvg93 svenvg93 mentioned this pull request Jun 26, 2024
Merged
@svenvg93
Copy link
Contributor Author

@alexjustesen not push you, do you have any idea when these notifications pr will be merged. So can start working on the other item for adding the speedtest url in the notification

@alexjustesen
Copy link
Owner

@alexjustesen not push you, do you have any idea when these notifications pr will be merged. So can start working on the other item for adding the speedtest url in the notification

I'd say probably this time next week. I'm catching up on client work (got to pay the bills) and then can re-focus my time on Speedtest Tracker without half-assing it.

@svenvg93
Copy link
Contributor Author

@alexjustesen not push you, do you have any idea when these notifications pr will be merged. So can start working on the other item for adding the speedtest url in the notification

I'd say probably this time next week. I'm catching up on client work (got to pay the bills) and then can re-focus my time on Speedtest Tracker without half-assing it.

No worries, bills need to get paid :)

@alexjustesen alexjustesen merged commit 987b099 into alexjustesen:develop-0.21.0 Jul 18, 2024
1 check passed
@svenvg93 svenvg93 deleted the 1556-add-healthcheck.io branch July 18, 2024 13:50
@alexjustesen alexjustesen mentioned this pull request Jul 18, 2024
Closed
12 tasks
@alexjustesen alexjustesen added this to the v0.x.0 (notifications) milestone Jul 18, 2024
alexjustesen added a commit that referenced this pull request Aug 8, 2024
@alexjustesen @svenvg93
Develop v0.21.0 (additional notification channels) (#1647)
96f9dd3 
* Add Placeholder text for notifications (#1570)

first_commit

* Add Gotify Notifications via Webhook (#1561)

* first_commit

* Ready!

* Add_placeholder

* change url

---------

Co-authored-by: Alex Justesen <[email protected]>

* Add Support for Slack Notifications via Webhook (#1522)

* First Commit

* Fix lint

* add_url_placeholder

* Fix the liniting

* Add HealthCheck.io Notifications via Webhooks (#1567)

* first_commit

* linting

* add_descrip_for_threshold

* Change name

* add_url_placeholder

* fix_linting

* Add Pushover Notifications via Webhooks (#1574)

* add_pushover

* add_placeholder

* Linting

---------

Co-authored-by: Alex Justesen <[email protected]>

* Add ntfy Notifications via Webhooks (#1579)

* first_push

* Fix_json_payload

* Add_auth_option

* fix lint

* fix packet_loss_%

* added eof line

---------

Co-authored-by: Alex Justesen <[email protected]>

* Add Ookla URL to the notification (#1615)

* first commit

* added eof line

---------

Co-authored-by: Alex Justesen <[email protected]>

* Fix notifications layouts (#1639)

first commit

---------

Co-authored-by: Sven van Ginkel <[email protected]>
alexjustesen added a commit that referenced this pull request Aug 8, 2024
@alexjustesen @svenvg93
Release v0.21.0 (#1648)
362311c 
* Develop v0.21.0 (additional notification channels) (#1647)

* Add Placeholder text for notifications (#1570)

first_commit

* Add Gotify Notifications via Webhook (#1561)

* first_commit

* Ready!

* Add_placeholder

* change url

---------

Co-authored-by: Alex Justesen <[email protected]>

* Add Support for Slack Notifications via Webhook (#1522)

* First Commit

* Fix lint

* add_url_placeholder

* Fix the liniting

* Add HealthCheck.io Notifications via Webhooks (#1567)

* first_commit

* linting

* add_descrip_for_threshold

* Change name

* add_url_placeholder

* fix_linting

* Add Pushover Notifications via Webhooks (#1574)

* add_pushover

* add_placeholder

* Linting

---------

Co-authored-by: Alex Justesen <[email protected]>

* Add ntfy Notifications via Webhooks (#1579)

* first_push

* Fix_json_payload

* Add_auth_option

* fix lint

* fix packet_loss_%

* added eof line

---------

Co-authored-by: Alex Justesen <[email protected]>

* Add Ookla URL to the notification (#1615)

* first commit

* added eof line

---------

Co-authored-by: Alex Justesen <[email protected]>

* Fix notifications layouts (#1639)

first commit

---------

Co-authored-by: Sven van Ginkel <[email protected]>

* updated npm dependencies

---------

Co-authored-by: Sven van Ginkel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjustesen alexjustesen alexjustesen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.x.0 (notifications)
Development

Successfully merging this pull request may close these issues.

Healthcheck.io integration
2 participants
@svenvg93 @alexjustesen