-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow component names to start with _ #425
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! One edge case that would be good to fix, but other than that looks good!
I can look into the test failures; they seem unrelated to your change.
@yang tests should be fixed now! Can you rebase? Also would be good to switch to the |
Codecov Report
@@ Coverage Diff @@
## master #425 +/- ##
==========================================
- Coverage 80.09% 80.07% -0.02%
==========================================
Files 47 47
Lines 5264 5040 -224
Branches 1174 1175 +1
==========================================
- Hits 4216 4036 -180
+ Misses 744 702 -42
+ Partials 304 302 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 thanks!
@yang Thanks, I just published as 3.9.6. |
Fixes #424