Allow component names to start with _

Fixes #424
alangpierce · Feb 28, 2019 · f9f5e36 · f9f5e36
1 parent 4593c51
commit f9f5e36
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/transformers/JSXTransformer.ts b/src/transformers/JSXTransformer.ts
@@ -3,6 +3,7 @@ import {Options} from "../index";
 import NameManager from "../NameManager";
 import XHTMLEntities from "../parser/plugins/jsx/xhtml";
 import {TokenType as tt} from "../parser/tokenizer/types";
+import {charCodes} from "../parser/util/charcodes";
 import TokenProcessor from "../TokenProcessor";
 import getJSXPragmaInfo, {JSXPragmaInfo} from "../util/getJSXPragmaInfo";
 import RootTransformer from "./RootTransformer";
@@ -252,7 +253,8 @@ export default class JSXTransformer extends Transformer {
 }
 
 export function startsWithLowerCase(s: string): boolean {
-  return s[0] === s[0].toLowerCase();
+  const firstChar = s.charCodeAt(0);
+  return firstChar >= charCodes.lowercaseA && firstChar <= charCodes.lowercaseZ;
 }
 
 /**

diff --git a/test/jsx-test.ts b/test/jsx-test.ts
@@ -37,6 +37,17 @@ describe("transform JSX", () => {
     );
   });
 
+  it("handles component names starting with _", () => {
+    assertResult(
+      `
+      <_Foo />
+    `,
+      `${JSX_PREFIX}
+      React.createElement(_Foo, {${devProps(2)}} )
+    `,
+    );
+  });
+
   it("transforms nested JSX elements", () => {
     assertResult(
       `