Allow component names to start with _

Fixes #424
alangpierce · Feb 28, 2019 · 0bac644 · 0bac644
1 parent d94e66f
commit 0bac644
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/transformers/JSXTransformer.ts b/src/transformers/JSXTransformer.ts
@@ -252,7 +252,7 @@ export default class JSXTransformer extends Transformer {
 }
 
 export function startsWithLowerCase(s: string): boolean {
-  return s[0] === s[0].toLowerCase();
+  return s[0] !== s[0].toUpperCase();
 }
 
 /**

diff --git a/test/jsx-test.ts b/test/jsx-test.ts
@@ -37,6 +37,17 @@ describe("transform JSX", () => {
     );
   });
 
+  it("handles component names starting with _", () => {
+    assertResult(
+      `
+      <_Foo />
+    `,
+      `${JSX_PREFIX}
+      React.createElement(_Foo, {${devProps(2)}} )
+    `,
+    );
+  });
+
   it("transforms nested JSX elements", () => {
     assertResult(
       `
-Original file line number
+Diff line change
@@ Expand Up / @@ -252,7 +252,7 @@ export default class JSXTransformer extends Transformer { @@
     }
     export function startsWithLowerCase(s: string): boolean {
-      return s[0] === s[0].toLowerCase();
+      return s[0] !== s[0].toUpperCase();
     }
     /**
@@ Expand Down @@