-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fail JournalSerializationSpec.Journal_should_serialize_Persistent_with_EventAdapter_manifes #3964
Draft
Aaronontheweb
wants to merge
3
commits into
akkadotnet:dev
Choose a base branch
from
Aaronontheweb:fix-AkkaPersistence-EventAdapterWithManifest
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
fail JournalSerializationSpec.Journal_should_serialize_Persistent_with_EventAdapter_manifes #3964
Aaronontheweb
wants to merge
3
commits into
akkadotnet:dev
from
Aaronontheweb:fix-AkkaPersistence-EventAdapterWithManifest
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h_EventAdapter_manifest doesn't make sense
Aaronontheweb
added
NO MERGE
Don't merge.
bug-reproduction
Used to reproduce bugs.
labels
Oct 8, 2019
Ok, I figured this issue out. It's not a bug - we need to add some missing HOCON to this spec in order to get it to work:
|
Nevermind - this spec fails because we're not saving messages using the |
|
Aaronontheweb
added a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Oct 28, 2019
Aaronontheweb
added a commit
that referenced
this pull request
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduction to show that this spec doesn't make sense right now.