Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Akka.Persistence.TCK: JournalSerializationSpec.Journal_should_serialize_Persistent_with_EventAdapter_manifest doesn't make sense #3965

Open
Aaronontheweb opened this issue Oct 8, 2019 · 1 comment
Open

Akka.Persistence.TCK: JournalSerializationSpec.Journal_should_serialize_Persistent_with_EventAdapter_manifest doesn't make sense #3965

Aaronontheweb opened this issue Oct 8, 2019 · 1 comment
Labels
akka-persistence confirmed bug tests

Comments

@Aaronontheweb
Copy link
Member

Aaronontheweb commented Oct 8, 2019 •
edited
Loading

Version: v1.4.0-beta2

Reproduction: #3964

Fixed a bug in the EventJournal for Akka.Persistence.Sql.Common that caused IWriteAdapter.Manifest output to ultimately be ignored during serialization, but this caused the test to fail only differently than before. As this spec is currently implemented, there are no conditions under which this test can pass.
@Aaronontheweb Aaronontheweb added this to the 1.4.0 milestone Oct 8, 2019
@Aaronontheweb
Copy link
Member Author

I'll add more details here once the CI system gives me some sharable test results.

This was referenced Oct 8, 2019
Merged
Closed
Aaronontheweb added a commit to Aaronontheweb/Akka.Persistence.Azure that referenced this issue Oct 8, 2019
@Aaronontheweb
disabled spec that can't pass due to akkadotnet/akka.net#3965
fbef031
Aaronontheweb added a commit to petabridge/Akka.Persistence.Azure that referenced this issue Oct 9, 2019
@Aaronontheweb
added TCK SerializationSpecs (#58)
257c30d 
* added TCK SerializationSpecs

* disabled spec that can't pass due to akkadotnet/akka.net#3965
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.0, 1.4.1 and Later Feb 11, 2020
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.2, 1.4.3, 1.4.4 Mar 13, 2020
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.4, 1.4.5 Mar 31, 2020
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.5, 1.4.6 Apr 29, 2020
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.6, 1.4.7 May 12, 2020
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.7, 1.4.8 May 26, 2020
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.8, 1.4.9 Jun 17, 2020
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.9, 1.4.10 Jul 21, 2020
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.10, 1.4.11 Aug 20, 2020
@Aaronontheweb Aaronontheweb removed this from the 1.4.11 milestone Nov 5, 2020
@Aaronontheweb Aaronontheweb added this to the 1.4.33 milestone Jan 18, 2022
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.33, 1.4.34 Feb 14, 2022
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.34, 1.4.35 Mar 7, 2022
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.35, 1.4.36 Mar 18, 2022
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.36, 1.4.40 Jun 7, 2022
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.40, 1.4.41 Jul 27, 2022
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.41, 1.4.42 Sep 7, 2022
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.42, 1.4.43, 1.4.44 Sep 23, 2022
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.44, 1.4.45, 1.4.46 Oct 17, 2022
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.46, 1.4.47 Nov 15, 2022
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.47, 1.4.48 Dec 9, 2022
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.48, 1.4.49 Jan 5, 2023
@Aaronontheweb Aaronontheweb modified the milestones: 1.4.49, 1.4.50 Jan 26, 2023
@Aaronontheweb Aaronontheweb removed this from the 1.4.50 milestone Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
akka-persistence confirmed bug tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Aaronontheweb