Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail JournalSerializationSpec.Journal_should_serialize_Persistent_with_EventAdapter_manifes #3964

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -691,19 +691,22 @@ protected virtual void WriteEvent(DbCommand command, IPersistentRepresentation e
var serializer = Serialization.FindSerializerForType(payloadType, Configuration.DefaultSerializer);

// TODO: hack. Replace when https://github.com/akkadotnet/akka.net/issues/3811
string manifest = "";
string manifest = e.Manifest;
var binary = Akka.Serialization.Serialization.WithTransport(Serialization.System, () =>
{

if (serializer is SerializerWithStringManifest stringManifest)
{
manifest = stringManifest.Manifest(e.Payload);
}
else

if (string.IsNullOrEmpty(manifest))
{
if (serializer.IncludeManifest)
if (serializer is SerializerWithStringManifest stringManifest)
{
manifest = e.Payload.GetType().TypeQualifiedName();
manifest = stringManifest.Manifest(e.Payload);
}
else
{
if (serializer.IncludeManifest)
{
manifest = e.Payload.GetType().TypeQualifiedName();
}
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,5 @@ class = ""Akka.Persistence.Sqlite.Journal.SqliteJournal, Akka.Persistence.Sqlite
}
}");
}

[Fact(Skip = "Sql plugin does not support EventAdapter.Manifest")]
public override void Journal_should_serialize_Persistent_with_EventAdapter_manifest()
{
}
}
}