Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No way to create a unencrypted HTTP/2 server with Java #2110

Closed
johanandren opened this issue Jul 5, 2018 · 1 comment
Closed

No way to create a unencrypted HTTP/2 server with Java #2110

johanandren opened this issue Jul 5, 2018 · 1 comment
Labels
3 - in progress Someone is working on this ticket t:http2 Issues related to support HTTP2 t:java Issues related to the Java DSL
Milestone
10.1.4

Comments

@johanandren
Copy link
Member

The juggling going on with the ConnectHttp in the Java version of bindAndHandleAsync will loose the Http2 flag when the context is not encrypted (effectiveConnectionContext always returns the fallbackContext which doesn't have http2 set since ConnectHttpImpl always has an empty connectionContext)
@johanandren johanandren added 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted t:java Issues related to the Java DSL t:http2 Issues related to support HTTP2 labels Jul 5, 2018
johanandren added a commit to johanandren/akka-http that referenced this issue Jul 5, 2018
@johanandren
Somewhat absurd fix allowing using cleartext HTTP/2 from Java akka#2110
f4f232d
@johanandren johanandren mentioned this issue Jul 5, 2018
Closed
johanandren added a commit to johanandren/akka-http that referenced this issue Jul 6, 2018
@johanandren
Allow using cleartext HTTP/2 from Java akka#2110
2626287
@johanandren johanandren added 3 - in progress Someone is working on this ticket and removed 1 - triaged Tickets that are safe to pick up for contributing in terms of likeliness of being accepted labels Jul 6, 2018
This was referenced Aug 16, 2018
Merged
Merged
@chbatey
Copy link
Member

chbatey commented Aug 16, 2018

Ahh didn't see this, would have saved me some time yesterday!

@raboof raboof added this to the 10.1.4 milestone Aug 17, 2018
@raboof raboof closed this as completed Aug 17, 2018
@raboof raboof mentioned this issue Aug 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3 - in progress Someone is working on this ticket t:http2 Issues related to support HTTP2 t:java Issues related to the Java DSL
Projects
None yet
Milestone
10.1.4
Development

No branches or pull requests
3 participants
@raboof @johanandren @chbatey