Update vanilla Akka gRPC to not use TLS in examples #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
approved these changes
Aug 15, 2018
|
We need to either revert the changes for Java or release Akka HTTP due to: akka/akka-http#2149 So don't merge for now |
|
I vote for releasing akka-http, was a while since we did anyway :) |
johanandren
reviewed
Aug 16, 2018
| @@ -27,7 +27,7 @@ This library is in preview mode: basic functionality is in place, but API's and | |||
| build system plugins are still expected to be improved. | |||
|
|
|||
| The API on both sides (Client and Server) is a simple Akka Streams-based one. | |||
| We plan to also provide a 'power user' API for each of these ([#191](https://github.com/akka/akka-grpc/issues/191), [#179](https://github.com/akka/akka-grpc/issues/179)). | |||
| The client has a 'power user' API and the planned for the server in [#179](https://github.com/akka/akka-grpc/issues/179)). | |||
There was a problem hiding this comment.
"and the planned for the server in"?
| @@ -63,54 +60,11 @@ public static void main(String[] args) throws Exception { | |||
|
|
|||
| Http.get(sys).bindAndHandleAsync( | |||
| serviceHandlers, | |||
| ConnectWithHttps.toHostHttps("127.0.0.1", 8080).withCustomHttpsContext(serverHttpContext()), | |||
| ConnectHttp.toHost("127.0.0.1", 8080, UseHttp2.always()), | |||
There was a problem hiding this comment.
Does this really work? akka/akka-http#2110
There was a problem hiding this comment.
No, see comment above. Needs an akka http release
chbatey
force-pushed
the
349-no-tls-in-examples
branch
from
9eec9cf to
875ea4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our examples just got a lot smaller