Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create publishable Play test artifact #359

Closed
richdougherty opened this issue Aug 21, 2018 · 3 comments
Closed

Create publishable Play test artifact #359

richdougherty opened this issue Aug 21, 2018 · 3 comments
Labels
play issues regarding play interoperability
Milestone

Comments

@richdougherty
Copy link
Contributor

Create an artifact that contains gRPC test helpers for Play that can be used with ScalaTest, specs2 and JUnit. The artifact will be used internally by the play-interop projects contained in the akka-grpc repo. It will also be used by our Play gRPC example projects. Users who want to test our pre-release versions of akka-grpc can use the artifact too.

In the future this artifact will be split into code that will live in the play-test, play-java, play-specs2 and scalatestplus-play artifacts. For now, we'll keep the code in a single artifact inside the akka-grpc repo so that it's faster for us to work with and improve. Since this artifact bundles together several different types of test frameworks, these dependencies should be marked as "provided" so that they don't automatically get pulled in when the artifact is used.

By request of the Akka team the artifact should contain the name "testkit". For example, it could be called something like "akka-grpc-play-testkit".

Depends on #356, which creates gRPC test helpers for ScalaTest and specs2.

We need to create this artifact before we can do several other things like add tests to our example code and add Java test helpers.

@richdougherty
Copy link
Contributor Author

Still waiting on #356. Until then I've prototyped the work here: master...richdougherty:play-testkit

@raboof
Copy link
Member

raboof commented Aug 27, 2018

Unfortunately we really want akka-http 10.1.4 because it contains the fix for akka/akka-http#2110.. perhaps we should consider cutting 10.1.5 relatively soon.

@richdougherty
Copy link
Contributor Author

I decided to move this into #356 anyway, since that PR was still not merged, and since I needed to rewrite how dependencies worked to get it compiling.

@raboof raboof added this to the invalid milestone Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
play issues regarding play interoperability
Projects
None yet
Development

No branches or pull requests

2 participants