Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Scala 2.11 support #521

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Drop Scala 2.11 support #521

merged 1 commit into from
Feb 6, 2019

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Feb 1, 2019

Fixes #520
Closes #497
Closes #498

@dwijnand dwijnand mentioned this pull request Feb 1, 2019
Closed
2 tasks
johanandren
johanandren approved these changes Feb 1, 2019
View reviewed changes
Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not 100% sure it is a good idea to drop 2.11 support when we still support it in Akka/Akka HTTP but if we have consensus on that is this is fine)

@dwijnand
Copy link
Member Author

dwijnand commented Feb 1, 2019

(JFYI I gave my reasons in #520)

jrudolph
jrudolph approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@jrudolph jrudolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's not encourage anyone to stay on 2.11. LGTM

patriknw
patriknw approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I agree

@jrudolph jrudolph merged commit f120823 into akka:master Feb 6, 2019
@jrudolph jrudolph added this to the 0.4.3 milestone Feb 6, 2019
@dwijnand dwijnand deleted the drop-211 branch February 6, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanandren johanandren johanandren approved these changes

@patriknw patriknw patriknw approved these changes

@jrudolph jrudolph jrudolph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@dwijnand @jrudolph @patriknw @johanandren