Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for scala 2.13 as well #506

Closed
2 tasks done
raboof opened this issue Jan 22, 2019 · 13 comments
Closed
2 tasks done

Build for scala 2.13 as well #506

raboof opened this issue Jan 22, 2019 · 13 comments
Milestone

Comments

@raboof
Copy link
Member

raboof commented Jan 22, 2019

Depends on

@dwijnand
Copy link
Member

dwijnand commented Feb 1, 2019

Note the diff in #521 for how to support for an addition Scala version is setup.

@raboof
Copy link
Member Author

raboof commented May 27, 2019

2.13.0-RC2 now depending on:

@raboof raboof mentioned this issue May 27, 2019
2 tasks
@dwijnand
Copy link
Member

ScalaPB 0.9.0-M7 was been released for Scala 2.13.0.

@dwijnand
Copy link
Member

Oh, fixed in #599, but unreleased for now.

@raboof
Copy link
Member Author

raboof commented Jul 11, 2019

Jup, we plan to release this after akka/akka-http#2590 (unless anyone wants to do an earlier release)

@raboof raboof added this to the 0.7.0 milestone Jul 17, 2019
@bjaglin
Copy link
Contributor

bjaglin commented Jul 19, 2019

I can't find 0.7.0 artifacts for scala 2.13 on maven central: https://repo1.maven.org/maven2/com/lightbend/akka/grpc/.

Is that expected?

@dwijnand
Copy link
Member

No... thanks for the report!

@raboof probably just need to change the

    - stage: publish
      script: sbt publish
      name: sbt publish

to sbt +publish.

@raboof
Copy link
Member Author

raboof commented Jul 20, 2019

Oops! Added #643, I'll look into pushing that one (either for 0.7.0 or a 0.7.1) somewhere next week.

@bjaglin
Copy link
Contributor

bjaglin commented Aug 6, 2019

@raboof I guess you decided not to publish a 2.13 artifact for 0.7.0? any idea on when you will cut 0.7.1? thanks!

@raboof
Copy link
Member Author

raboof commented Aug 6, 2019

Yeah, sorry about that! I can start cutting 0.7.1 at any time, but there's some interesting PR's that seem pretty close to being mergable, so I was waiting for those. If you have a need for 0.7.1 then I can start cutting it this week, otherwise I'd like to wait until more of those in-flight PR's are in.

@bjaglin
Copy link
Contributor

bjaglin commented Aug 6, 2019

No rush here, let's wait for those to get in indeed!

@jeffrey-aguilera
Copy link

Actually, sooner is better than later. This is holding up my project --- and many others --- from making the jump to 2.13.0. I would rather have the last version, but in 2.13.0 form, rather than wait for "interesting PRs".

@raboof
Copy link
Member Author

raboof commented Aug 9, 2019

I'll look into it next week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants