Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Java Client compiling with Scala 2.11 #497

Closed
dwijnand opened this issue Jan 17, 2019 · 1 comment
Closed

Fix Java Client compiling with Scala 2.11 #497

dwijnand opened this issue Jan 17, 2019 · 1 comment
Milestone
invalid

Comments

@dwijnand
Copy link
Member

It doesn't because it uses Java 8's method syntax and "scala.Function1 is not a functional interface" in Scala.11: https://travis-ci.com/playframework/play-grpc/jobs/171208483#L542

I'm not sure why this didn't fail in CI.

Originally posted by @dwijnand in #449
@dwijnand
Copy link
Member Author

The reason it didn't fail in CI is because 2.11 isn't tested during CI validation. For tags akka-grpc is published, however the tests have publishing disabled, so they never get compiled with Scala 2.11 either.

The solution to the CI problem is to +test:compile, either in CI validation, on master builds, or on tag builds.

This was referenced Jan 17, 2019
Closed
Closed
Merged
@dwijnand dwijnand mentioned this issue Feb 1, 2019
Merged
@raboof raboof added this to the invalid milestone Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
invalid
Development

No branches or pull requests
2 participants
@raboof @dwijnand