Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accessibility attributes back into autocomplete popup lines #5059

Merged
merged 3 commits into from Feb 15, 2023
Merged

Add accessibility attributes back into autocomplete popup lines #5059

merged 3 commits into from Feb 15, 2023

Conversation

ghost
Copy link

@ghost ghost commented Feb 14, 2023

3 changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ghost ghost changed the title Ace line fix 2 Add accesibility attributes back into autocomplete popup lines Feb 14, 2023
@ghost ghost marked this pull request as ready for review February 14, 2023 13:39
@ghost
Copy link
Author

ghost commented Feb 14, 2023

Tests are failing because of a issue in master branch. Waiting for fix to rebase.

@ghost ghost mentioned this pull request Feb 14, 2023
@ghost ghost changed the title Add accesibility attributes back into autocomplete popup lines Add accessibility attributes back into autocomplete popup lines Feb 14, 2023
Copy link
Contributor

@InspiredGuy InspiredGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please make sure that tests are not failing in your branch before merging.

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 86.20% // Head: 86.20% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (4b4528d) compared to base (30fc3ea).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5059   +/-   ##
=======================================
  Coverage   86.20%   86.20%           
=======================================
  Files         548      548           
  Lines       41700    41703    +3     
  Branches     6564     6564           
=======================================
+ Hits        35949    35952    +3     
  Misses       5751     5751           
Flag Coverage Δ
unittests 86.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/autocomplete/popup.js 78.76% <100.00%> (+0.28%) ⬆️
src/autocomplete_test.js 97.50% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@InspiredGuy InspiredGuy merged commit 07dc157 into ajaxorg:master Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant