-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocomplete accessibility features #5008
Conversation
Codecov ReportBase: 86.11% // Head: 86.11% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5008 +/- ##
=======================================
Coverage 86.11% 86.11%
=======================================
Files 546 546
Lines 41600 41627 +27
Branches 6553 6555 +2
=======================================
+ Hits 35822 35847 +25
- Misses 5778 5780 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the current implementation we set an id of the selected element in the autocomplete and remove the id once the element is not selected/focussed. Why we need to do all of this? Can't we generate id once e.g. ace_line_{index} and set aria-activedescendant
when an item is selected? Ofc, we need to make sure that ids do not clash.
Issue #, if available:
Description of changes:
Adds necessary roles and aria-labels for the autocomplete popup.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.