Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line height regression #5052

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Fix line height regression #5052

merged 3 commits into from
Feb 7, 2023

Conversation

nightwing
Copy link
Member

fixes #5012

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@nightwing nightwing force-pushed the fix-line-height-regression branch from 98d2fcc to 75f5294 Compare February 7, 2023 10:54
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 86.14% // Head: 86.14% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (75f5294) compared to base (00f6089).
Patch coverage: 93.10% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5052   +/-   ##
=======================================
  Coverage   86.14%   86.14%           
=======================================
  Files         548      548           
  Lines       41703    41692   -11     
  Branches     6563     6563           
=======================================
- Hits        35926    35917    -9     
+ Misses       5777     5775    -2     
Flag Coverage Δ
unittests 86.14% <93.10%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/layer/text.js 91.98% <81.81%> (+0.24%) ⬆️
src/autocomplete_test.js 97.50% <100.00%> (ø)
src/ext/static_highlight_test.js 98.48% <100.00%> (ø)
src/layer/font_metrics.js 89.60% <100.00%> (-0.09%) ⬇️
src/layer/text_test.js 98.11% <100.00%> (ø)
src/virtual_renderer.js 79.81% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACE line heights since 1.13.1
2 participants