876: Allow pending transactions to be saved in localStorage (and big refactor) #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
March 27, 2024 16:18
ghost
changed the title
dmosites
approved these changes
Apr 2, 2024
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #876
I had to do a big refactor regarding everything around transactions. The handling of it was spread around multiple files so I consolidated it to the transactions store.
Also I got some import cycle errors so I had to rewrite some functions that used createAsyncThunk.
Some testing of the approving, wrapping and taking orders would be appreciated.
Some other issues that I found but is beyond the scope of this ticket:
#888
#889