Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate balance handling in balances store #889

Closed
ghost opened this issue Mar 27, 2024 · 0 comments · Fixed by #898
Closed

Consolidate balance handling in balances store #889

ghost opened this issue Mar 27, 2024 · 0 comments · Fixed by #898

Comments

@ghost
Copy link

ghost commented Mar 27, 2024 •
edited by ghost
Loading

Right now approvals and transfers are handled in balancesApi. Some of it is working but sometimes balances don't get updated after a successful transaction.

And deposits and withdraws should also be in there. Right now that's handles in ordersActions. It should be moved to balancesApi.
@ghost ghost added this to DEX 🔷 Mar 27, 2024
@ghost ghost converted this from a draft issue Mar 27, 2024
@ghost ghost self-assigned this Mar 27, 2024
@ghost ghost mentioned this issue Mar 27, 2024
Merged
@ghost ghost moved this from ToDo to In Progress in DEX 🔷 Apr 16, 2024
@ghost ghost mentioned this issue Apr 18, 2024
Merged
@ghost ghost closed this as completed in #898 Apr 25, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in DEX 🔷 Apr 25, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
DEX 🔷
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

889: Consolidated balance handling in balances store airswap/airswap-web
0 participants