Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix historical transactions #888

Open
ghost opened this issue Mar 27, 2024 · 0 comments
Open

Fix historical transactions #888

ghost opened this issue Mar 27, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Mar 27, 2024

In useSwapLogs the filters no longer work.

const signerSwapFilter = swapContract.filters.SwapERC20(
          null, // nonce
          account, // signerWallet
          null, // signerToken
          null, // signerAmount,
          null, // protocol fee
          null, // senderWallet
          null, // senderToken
          null // senderAmount
      );

Now it only takes nonce and signerWallet. This still works but now all the Events only have a nonce and signerWallet. So we're no longer able to build historical transactions using this method

@ghost ghost added this to DEX 🔷 Mar 27, 2024
@ghost ghost converted this from a draft issue Mar 27, 2024
@ghost ghost added the bug Something isn't working label Mar 27, 2024
@ghost ghost self-assigned this Mar 27, 2024
@ghost ghost moved this from ToDo to In Progress in DEX 🔷 Mar 29, 2024
@ghost ghost moved this from In Progress to Done in DEX 🔷 Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

0 participants