Use NPM clean install and upgrade node to v18 #8140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8140 +/- ##
==========================================
+ Coverage 97.41% 97.50% +0.09%
==========================================
Files 107 107
Lines 32732 32745 +13
Branches 3823 3829 +6
==========================================
+ Hits 31885 31928 +43
+ Misses 640 615 -25
+ Partials 207 202 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
steverep
commented
Feb 8, 2024
Backport to 3.9: 💚 backport PR created✅ Backport PR branch: Backported as #8149 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
(cherry picked from commit d2ea811)
5 tasks
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #8150 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Feb 9, 2024
(cherry picked from commit d2ea811)
5 tasks
Dreamsorcerer
pushed a commit
that referenced
this pull request
Feb 9, 2024
…node to v18 (#8150) **This is a backport of PR #8140 as merged into master (d2ea811).** Co-authored-by: Steve Repsher <[email protected]>
Dreamsorcerer
pushed a commit
that referenced
this pull request
Feb 9, 2024
…ode to v18 (#8149) **This is a backport of PR #8140 as merged into master (d2ea811).** Co-authored-by: Steve Repsher <[email protected]>
5 tasks
webknjaz
added a commit
to webknjaz/aiohttp
that referenced
this pull request
Feb 16, 2024
…ia asyncio protocols This is supposed to unify setting exceptions on the future objects, allowing to also attach their causes whenever available. It'll make possible for the end-users to see more detailed tracebacks. It's also supposed to help with tracking down what's happening with aio-libs#4581. PR aio-libs#8089 Co-Authored-By: J. Nick Koston <[email protected]> Co-Authored-By: Sam Bull <[email protected]> (cherry picked from commit dc38630)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
llhttpusingnpm cifor security and to preserve the lock file. This command should always be used in CI.llhttpDockerfile is using)Are there changes in behavior for the user?
No
Is it a substantial burden for the maintainers to support this?
No
Related issue number
Fixes #8116
Checklist
CONTRIBUTORS.txtCHANGES/foldername it
<issue_or_pr_num>.<type>.rst(e.g.588.bugfix.rst)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature: A new behavior, public APIs. That sort of stuff..deprecation: A declaration of future API removals and breakingchanges in behavior.
.breaking: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc: Notable updates to the documentation structure or buildprocess.
.packaging: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.