Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8140/d2ea8118 backport][3.10] Use NPM clean install and upgrade node to v18 #8150

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Feb 9, 2024

This is a backport of PR #8140 as merged into master (d2ea811).

What do these changes do?

  • Installs llhttp using npm ci for security and to preserve the lock file. This command should always be used in CI.
  • Upgrades Node.js from v14 (out of maintenance) to v18 (current LTS maintenance release and also what the llhttp Dockerfile is using)

Are there changes in behavior for the user?

No

Is it a substantial burden for the maintainers to support this?

No

Related issue number

Fixes #8116

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

@patchback patchback bot requested review from webknjaz and asvetlov as code owners February 9, 2024 01:21
@Dreamsorcerer Dreamsorcerer enabled auto-merge (squash) February 9, 2024 01:36
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1dc8a07) 97.44% compared to head (181118b) 97.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.10    #8150   +/-   ##
=======================================
  Coverage   97.44%   97.44%           
=======================================
  Files         108      108           
  Lines       32937    32937           
  Branches     3932     3932           
=======================================
  Hits        32097    32097           
  Misses        637      637           
  Partials      203      203           
Flag Coverage Δ
CI-GHA 97.36% <ø> (ø)
OS-Linux 97.05% <ø> (ø)
OS-Windows 94.59% <ø> (ø)
OS-macOS 96.87% <ø> (ø)
Py-3.10.11 94.49% <ø> (ø)
Py-3.10.13 96.83% <ø> (ø)
Py-3.11.7 96.51% <ø> (ø)
Py-3.12.1 96.47% <ø> (ø)
Py-3.8.10 94.47% <ø> (-0.01%) ⬇️
Py-3.8.18 96.77% <ø> (ø)
Py-3.9.13 94.48% <ø> (ø)
Py-3.9.18 96.82% <ø> (ø)
Py-pypy7.3.15 96.34% <ø> (ø)
VM-macos 96.87% <ø> (ø)
VM-ubuntu 97.05% <ø> (ø)
VM-windows 94.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit eb397f3 into 3.10 Feb 9, 2024
26 of 29 checks passed
@Dreamsorcerer Dreamsorcerer deleted the patchback/backports/3.10/d2ea811853c2cb9305f7afe1a96265d31edb4f3b/pr-8140 branch February 9, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants