-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create hello.txt.gz dynamically and improve related assertions #8136
Conversation
What's with the random seg faults on PyPy? |
No idea, been doing it for about 3 months now and bumping to a newer version didn't help either... |
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8136 +/- ##
==========================================
+ Coverage 97.41% 97.51% +0.10%
==========================================
Files 107 107
Lines 32732 32734 +2
Branches 3823 3827 +4
==========================================
+ Hits 31885 31921 +36
+ Misses 640 612 -28
+ Partials 207 201 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, this patch is good, and addressing the weird assert await
places and other comments is optional. I'll let somebody else merge, though, in case there's extra opinions.
Tagging for backport since we want to pull the other PR on top of this and it will conflict otherwise |
I think this looks good. Some trivial nits in the docstrings above, but otherwise looks good to merge from my perspective. |
Co-authored-by: J. Nick Koston <[email protected]>
Co-authored-by: J. Nick Koston <[email protected]>
Backport to 3.9: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 026e8d9 on top of patchback/backports/3.9/026e8d9872ab4511c38578a8c784cd2e740f0448/pr-8136 Backporting merged PR #8136 into master
🤖 @patchback |
Thanks @steverep |
Backport to 3.10: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 026e8d9 on top of patchback/backports/3.10/026e8d9872ab4511c38578a8c784cd2e740f0448/pr-8136 Backporting merged PR #8136 into master
🤖 @patchback |
Looks like this one will need some manual backports. I was hoping it was going to merge back cleanly. |
I don't see anything that would actually conflict so it's probably trivial. I'll take care of it. |
…aio-libs#8136) (cherry picked from commit 026e8d9) Co-authored-by: Steve Repsher <[email protected]> Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]> Co-authored-by: J. Nick Koston <[email protected]>
…io-libs#8136) (cherry picked from commit 026e8d9) Co-authored-by: Steve Repsher <[email protected]> Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]> Co-authored-by: J. Nick Koston <[email protected]>
Done. Conflict was just |
…#8136) (#8156) Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]> Co-authored-by: J. Nick Koston <[email protected]>
…8136) (#8157) Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]> Co-authored-by: J. Nick Koston <[email protected]>
What do these changes do?
hello.txt*
dynamically to help satisfy the edict from Add server capability to check for Brotli compressed static files #8063 (comment)This is separate so it can be fully backported.
Are there changes in behavior for the user?
No
Is it a substantial burden for the maintainers to support this?
No
Related issue number
No
Checklist
CONTRIBUTORS.txt
CHANGES/
foldername it
<issue_or_pr_num>.<type>.rst
(e.g.588.bugfix.rst
)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix
: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature
: A new behavior, public APIs. That sort of stuff..deprecation
: A declaration of future API removals and breakingchanges in behavior.
.breaking
: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc
: Notable updates to the documentation structure or buildprocess.
.packaging
: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib
: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc
: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.