Adapt product registration to the new architecture #1146

jreidinger · 2024-04-12T07:21:23Z

Another change in set that switch web UI from using dbus to HTTP API. As part of this change the rust code is added to provide that HTTP API and also adapted web UI. It also fixes all relevant js tests.

Things discussed but postponed (due to size of change and time constraints ) in this change was:

move registration requirement from registration to product as it is highly coupled with it
provide all changed data in websocket signal, so client does not need to do another http call to get correct data

Matching trello card: https://trello.com/c/2bTZOnpB

rust/agama-server/src/software/web.rs

lslezak · 2024-04-12T08:40:15Z

rust/agama-lib/src/product/client.rs

+    pub async fn registration_requirement(&self) -> Result<RegistrationRequirement, ServiceError> {
+        let requirement = self.registration_proxy.requirement().await?;
+        // unknown number can happen only if we do programmer mistake
+        let result: RegistrationRequirement = requirement.try_into().unwrap();


What about simple ? instead of unwrap()?

problem with ? is that it is not ServiceError, so I will need to convert that error somehow ( doable as I own error ), but I think it is not worth effort.

jreidinger · 2024-04-16T20:08:59Z

I get this warning in FF using arch branch. @lslezak @imobachgs does it ring any bells to you?

Cookie “agamaToken” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite

imobachgs · 2024-04-17T06:23:03Z

I get this warning in FF using arch branch. @lslezak @imobachgs does it ring any bells to you?

Cookie “agamaToken” does not have a proper “SameSite” attribute value. Soon, cookies without the “SameSite” attribute or with an invalid value will be treated as “Lax”. This means that the cookie will no longer be sent in third-party contexts. If your application depends on this cookie being available in such contexts, please add the “SameSite=None“ attribute to it. To know more about the “SameSite“ attribute, read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite

I would say we do not need to send the cookies in third-party contexts. We could easily set the SameSite value in the atuh_cookie_from_token function.

imobachgs

In general, it looks good. Just a few suggestions.

rust/agama-lib/src/product/client.rs

imobachgs · 2024-04-18T06:31:29Z

rust/agama-server/src/software/web.rs

+async fn registration_requirement_changed_stream(
+    dbus: zbus::Connection,
+) -> Result<impl Stream<Item = Event>, Error> {
+    // TODO: move registration requirement to product in dbus and so just one event will be needed.


As we agreed, I will create a card for this.

imobachgs · 2024-04-18T06:34:20Z

rust/agama-server/src/software/web.rs

+/// Register product
+///
+/// * `state`: service state.
+#[utoipa::path(post, path = "/software/registration", responses(


I would most probably use PUT, as you are replacing (or creating) the resource.

well, if I use PUT, I will have to create it idempotent, which it is currently not.

Well, I am not sure. If you perform the same action with the same data several times, what changes? I would expect the result to be the same. But I am fine with using POST.

well, the change will be that after first successful registration the next one fails. Also we do not handle if you use different data. You have to first deregister and then can register with different data. We handle that automatic only when you change product.

rust/agama-server/src/software/web.rs

web/src/client/software.js

Co-authored-by: Imobach González Sosa <[email protected]>

jreidinger · 2024-04-18T20:55:38Z

JFYI testing of error response succeed:

After a few months of work, it is time to merge the `architecture_2024` branch into `master`. It is still a work-in-progress, but all the efforts should be go now against that branch. ## Pull requests * #1061 * #1064 * #1073 * #1074 * #1080 * #1089 * #1091 * #1092 * #1094 * #1095 * #1099 * #1100 * #1102 * #1103 * #1112 * #1114 * #1116 * #1117 * #1119 * #1120 * #1123 * #1126 * #1129 * #1130 * #1131 * #1132 * #1133 * #1134 * #1136 * #1139 * #1140 * #1143 * #1146 ## Other commits * 8efa41f * 9e2dec0

Prepare for releasing Agama 8. It includes the following pull requests: * #884 * #886 * #914 * #918 * #956 * #957 * #958 * #959 * #960 * #961 * #962 * #963 * #964 * #965 * #966 * #969 * #970 * #976 * #977 * #978 * #979 * #980 * #981 * #983 * #984 * #985 * #986 * #988 * #991 * #992 * #995 * #996 * #997 * #999 * #1003 * #1004 * #1006 * #1007 * #1008 * #1009 * #1010 * #1011 * #1012 * #1014 * #1015 * #1016 * #1017 * #1020 * #1022 * #1023 * #1024 * #1025 * #1027 * #1028 * #1029 * #1030 * #1031 * #1032 * #1033 * #1034 * #1035 * #1036 * #1038 * #1039 * #1041 * #1042 * #1043 * #1045 * #1046 * #1047 * #1048 * #1052 * #1054 * #1056 * #1057 * #1060 * #1061 * #1062 * #1063 * #1064 * #1066 * #1067 * #1068 * #1069 * #1071 * #1072 * #1073 * #1074 * #1075 * #1079 * #1080 * #1081 * #1082 * #1085 * #1086 * #1087 * #1088 * #1089 * #1090 * #1091 * #1092 * #1093 * #1094 * #1095 * #1096 * #1097 * #1098 * #1099 * #1100 * #1102 * #1103 * #1104 * #1105 * #1106 * #1109 * #1110 * #1111 * #1112 * #1114 * #1116 * #1117 * #1118 * #1119 * #1120 * #1121 * #1122 * #1123 * #1125 * #1126 * #1127 * #1128 * #1129 * #1130 * #1131 * #1132 * #1133 * #1134 * #1135 * #1136 * #1138 * #1139 * #1140 * #1141 * #1142 * #1143 * #1144 * #1145 * #1146 * #1147 * #1148 * #1149 * #1151 * #1152 * #1153 * #1154 * #1155 * #1156 * #1157 * #1158 * #1160 * #1161 * #1162 * #1163 * #1164 * #1165 * #1166 * #1167 * #1168 * #1169 * #1170 * #1171 * #1172 * #1173 * #1174 * #1175 * #1177 * #1178 * #1180 * #1181 * #1182 * #1183 * #1184 * #1185 * #1187 * #1188 * #1189 * #1190 * #1191 * #1192 * #1193 * #1194 * #1195 * #1196 * #1198 * #1199 * #1200 * #1201 * #1203 * #1204 * #1205 * #1206 * #1207 * #1208 * #1209 * #1210 * #1211 * #1212 * #1213 * #1214 * #1215 * #1216 * #1217 * #1219 * #1220 * #1221 * #1222 * #1223 * #1224 * #1225 * #1226 * #1227 * #1229

jreidinger added 3 commits April 11, 2024 17:54

add missing methods to registration client

832ca75

add routes for registration

29627ef

implement registration streams

d2ad081

imobachgs reviewed Apr 12, 2024

View reviewed changes

rust/agama-server/src/software/web.rs Show resolved Hide resolved

imobachgs reviewed Apr 12, 2024

View reviewed changes

rust/agama-server/src/software/web.rs Show resolved Hide resolved

lslezak reviewed Apr 12, 2024

View reviewed changes

jreidinger added 3 commits April 12, 2024 23:23

adapt frontend

121c472

fix questions in UI

06c6c35

fixes from manual testing

f8b4ca5

format rust code

3d536a0

jreidinger force-pushed the registration_adapt branch from 3604c13 to 3d536a0 Compare April 17, 2024 10:28

jreidinger added 4 commits April 17, 2024 13:46

fix software js tests

e622e16

fix product page js test

21236b9

fix product section test and re-enable again issues

5773197

fix product selection js test

809221b

jreidinger marked this pull request as ready for review April 17, 2024 14:01

imobachgs changed the title ~~Registration adapt~~ Adapt product registration to the new architecture Apr 18, 2024

imobachgs reviewed Apr 18, 2024

View reviewed changes

jreidinger and others added 3 commits April 18, 2024 22:53

Update rust/agama-lib/src/product/client.rs

8d609a7

Co-authored-by: Imobach González Sosa <[email protected]>

implement better error handling for registration and deregistration

c08a679

changes from review

fcb2222

imobachgs approved these changes Apr 19, 2024

View reviewed changes

jreidinger merged commit b43af77 into architecture_2024 Apr 19, 2024
4 checks passed

jreidinger deleted the registration_adapt branch April 19, 2024 06:35

imobachgs mentioned this pull request May 6, 2024

Merge architecture_2024 branch into master #1177

Merged

imobachgs mentioned this pull request May 17, 2024

Update to release 8 #1232

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adapt product registration to the new architecture #1146

Adapt product registration to the new architecture #1146

jreidinger commented Apr 12, 2024 •

edited

Loading

lslezak Apr 12, 2024

jreidinger Apr 12, 2024

jreidinger commented Apr 16, 2024

imobachgs commented Apr 17, 2024

imobachgs left a comment

imobachgs Apr 18, 2024

imobachgs Apr 18, 2024

jreidinger Apr 18, 2024

imobachgs Apr 18, 2024

jreidinger Apr 18, 2024

jreidinger commented Apr 18, 2024

Adapt product registration to the new architecture #1146

Adapt product registration to the new architecture #1146

Conversation

jreidinger commented Apr 12, 2024 • edited Loading

lslezak Apr 12, 2024

Choose a reason for hiding this comment

jreidinger Apr 12, 2024

Choose a reason for hiding this comment

jreidinger commented Apr 16, 2024

imobachgs commented Apr 17, 2024

imobachgs left a comment

Choose a reason for hiding this comment

imobachgs Apr 18, 2024

Choose a reason for hiding this comment

imobachgs Apr 18, 2024

Choose a reason for hiding this comment

jreidinger Apr 18, 2024

Choose a reason for hiding this comment

imobachgs Apr 18, 2024

Choose a reason for hiding this comment

jreidinger Apr 18, 2024

Choose a reason for hiding this comment

jreidinger commented Apr 18, 2024

jreidinger commented Apr 12, 2024 •

edited

Loading