Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: Improve find space #1128

Merged

Conversation

joseivanlopez
Copy link
Contributor

@joseivanlopez joseivanlopez commented Apr 4, 2024

Improvements in the dialog to find space:

  • Includes the unused space.
  • Show devices and slots sorted by position.
  • The colums Device and *Details show similar information to the Result table.
  • Remove Size details in favor of Shrinkable column.

Code improvements:

  • Remove ProposalSpacePolicyField in favor of SpacePolicyDialog component, following the same apprach that the dialogs for boot and device configuration.
  • Enable type checking in several components.
  • Add more options to TreeTable (expandable rows, expadedItems props).

Screenshots

localhost_8080_ (34)

@joseivanlopez joseivanlopez force-pushed the find-space-improvements branch from eb83689 to bf50f4b Compare April 8, 2024 12:16
@coveralls
Copy link

coveralls commented Apr 8, 2024

Coverage Status

coverage: 74.669% (-0.1%) from 74.773%
when pulling 816ae4d on joseivanlopez:find-space-improvements
into 2fb60f8 on openSUSE:master.

@joseivanlopez joseivanlopez force-pushed the find-space-improvements branch 3 times, most recently from d26f7de to 6dd7cf6 Compare April 8, 2024 14:13
@joseivanlopez joseivanlopez force-pushed the find-space-improvements branch from 6958efa to 2c76047 Compare April 8, 2024 14:31
@joseivanlopez joseivanlopez marked this pull request as ready for review April 8, 2024 14:33
- Add missing mock.
Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thanks! 👍

<ProposalSpacePolicyField
policy={settings.spacePolicy}
actions={settings.spaceActions}
<SpacePolicyField
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been thinking on drop the Proposal prefix from these fields too. In fact, I talked about it with @ancorgs in a call discussing about the PBI I'm working on. However, I believe would be better to move it field to its own file. We can see it in the context of my PBI.

@joseivanlopez joseivanlopez merged commit 05ea8cd into agama-project:master Apr 8, 2024
1 check passed
@imobachgs imobachgs mentioned this pull request May 17, 2024
imobachgs added a commit that referenced this pull request May 17, 2024
Prepare for releasing Agama 8. It includes the following pull requests:

* #884
* #886
* #914
* #918
* #956
* #957
* #958
* #959
* #960
* #961
* #962
* #963
* #964
* #965
* #966
* #969
* #970
* #976
* #977
* #978
* #979
* #980
* #981
* #983
* #984
* #985
* #986
* #988
* #991
* #992
* #995
* #996
* #997
* #999
* #1003
* #1004
* #1006
* #1007
* #1008
* #1009
* #1010
* #1011
* #1012
* #1014
* #1015
* #1016
* #1017
* #1020
* #1022
* #1023
* #1024
* #1025
* #1027
* #1028
* #1029
* #1030
* #1031
* #1032
* #1033
* #1034
* #1035
* #1036
* #1038
* #1039
* #1041
* #1042
* #1043
* #1045
* #1046
* #1047
* #1048
* #1052
* #1054
* #1056
* #1057
* #1060
* #1061
* #1062
* #1063
* #1064
* #1066
* #1067
* #1068
* #1069
* #1071
* #1072
* #1073
* #1074
* #1075
* #1079
* #1080
* #1081
* #1082
* #1085
* #1086
* #1087
* #1088
* #1089
* #1090
* #1091
* #1092
* #1093
* #1094
* #1095
* #1096
* #1097
* #1098
* #1099
* #1100
* #1102
* #1103
* #1104
* #1105
* #1106
* #1109
* #1110
* #1111
* #1112
* #1114
* #1116
* #1117
* #1118
* #1119
* #1120
* #1121
* #1122
* #1123
* #1125
* #1126
* #1127
* #1128
* #1129
* #1130
* #1131
* #1132
* #1133
* #1134
* #1135
* #1136
* #1138
* #1139
* #1140
* #1141
* #1142
* #1143
* #1144
* #1145
* #1146
* #1147
* #1148
* #1149
* #1151
* #1152
* #1153
* #1154
* #1155
* #1156
* #1157
* #1158
* #1160
* #1161
* #1162
* #1163
* #1164
* #1165
* #1166
* #1167
* #1168
* #1169
* #1170
* #1171
* #1172
* #1173
* #1174
* #1175
* #1177
* #1178
* #1180
* #1181
* #1182
* #1183
* #1184
* #1185
* #1187
* #1188
* #1189
* #1190
* #1191
* #1192
* #1193
* #1194
* #1195
* #1196
* #1198
* #1199
* #1200
* #1201
* #1203
* #1204
* #1205
* #1206
* #1207
* #1208
* #1209
* #1210
* #1211
* #1212
* #1213
* #1214
* #1215
* #1216
* #1217
* #1219
* #1220
* #1221
* #1222
* #1223
* #1224
* #1225
* #1226
* #1227
* #1229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants