Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt the software UI to the new HTTP/JSON API #1112

Merged
merged 27 commits into from
Mar 25, 2024

Conversation

imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Mar 22, 2024

The initial idea was to adapt the software page and the patterns selector to the new HTTP-based API. However, we took the chance to revamp the software page to make it more similar to other Agama parts.

New software page

software-page

New patterns selector

software-selection

Changes summary

  • Introduce a new software page that lists the patterns to install.
  • Move the patterns selector to a pop-up.
  • Introduce small changes to the software API.
  • Update the JavaScript tests and enable the type checking on the new code.

What is missing

  • Distinguish between user and automatically selected patterns.

Out of scope

  • Improve the wording.

@coveralls
Copy link

coveralls commented Mar 22, 2024

Coverage Status

coverage: 72.103% (-0.002%) from 72.105%
when pulling 5b937df on adapt-software-ui
into bc95d15 on architecture_2024.

@imobachgs imobachgs marked this pull request as ready for review March 25, 2024 10:02
@mchf
Copy link
Contributor

mchf commented Mar 25, 2024

What is in rust & ruby LGTM

web/src/client/software.js Outdated Show resolved Hide resolved
web/src/client/software.js Outdated Show resolved Hide resolved
web/src/client/software.js Outdated Show resolved Hide resolved
web/src/client/software.js Show resolved Hide resolved
web/src/client/software.js Show resolved Hide resolved
web/src/client/software.test.js Show resolved Hide resolved
Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go! Thanks 👍🏼

@imobachgs imobachgs merged commit 030b4cc into architecture_2024 Mar 25, 2024
6 checks passed
@imobachgs imobachgs deleted the adapt-software-ui branch March 25, 2024 15:00
dgdavid added a commit that referenced this pull request Apr 2, 2024
In #1112, the _Patterns selector_ was changed to be more consistent with
the rest of the UI selection dialogs. However, the _core/Selector_
component used under the hood wasn't ready to handle auto selection. A
partial adaptation was made by allowing overriding how it behaves when
an option is clicked (see 61b0c0f), but the UI part is being addressed
here by

* Improving how the information is layout
* Letting the user know which patterns are auto selected
  - Using a different _accent-color_ for the checkbox.
  - Adding the "auto selected" text below the checkbox, since a
just a different checkbox style (whatever we choose) is not enough for
letting the user know that it has been auto selected pattern in a quick
way.
imobachgs added a commit that referenced this pull request May 6, 2024
After a few months of work, it is time to merge the `architecture_2024`
branch into `master`. It is still a work-in-progress, but all the
efforts should be go now against that branch.

## Pull requests

* #1061
* #1064
* #1073
* #1074
* #1080
* #1089
* #1091
* #1092
* #1094
* #1095
* #1099
* #1100
* #1102
* #1103
* #1112
* #1114
* #1116
* #1117
* #1119
* #1120
* #1123
* #1126
* #1129
* #1130
* #1131
* #1132
* #1133
* #1134
* #1136
* #1139
* #1140
* #1143
* #1146

## Other commits

* 8efa41f
* 9e2dec0
@imobachgs imobachgs mentioned this pull request May 17, 2024
imobachgs added a commit that referenced this pull request May 17, 2024
Prepare for releasing Agama 8. It includes the following pull requests:

* #884
* #886
* #914
* #918
* #956
* #957
* #958
* #959
* #960
* #961
* #962
* #963
* #964
* #965
* #966
* #969
* #970
* #976
* #977
* #978
* #979
* #980
* #981
* #983
* #984
* #985
* #986
* #988
* #991
* #992
* #995
* #996
* #997
* #999
* #1003
* #1004
* #1006
* #1007
* #1008
* #1009
* #1010
* #1011
* #1012
* #1014
* #1015
* #1016
* #1017
* #1020
* #1022
* #1023
* #1024
* #1025
* #1027
* #1028
* #1029
* #1030
* #1031
* #1032
* #1033
* #1034
* #1035
* #1036
* #1038
* #1039
* #1041
* #1042
* #1043
* #1045
* #1046
* #1047
* #1048
* #1052
* #1054
* #1056
* #1057
* #1060
* #1061
* #1062
* #1063
* #1064
* #1066
* #1067
* #1068
* #1069
* #1071
* #1072
* #1073
* #1074
* #1075
* #1079
* #1080
* #1081
* #1082
* #1085
* #1086
* #1087
* #1088
* #1089
* #1090
* #1091
* #1092
* #1093
* #1094
* #1095
* #1096
* #1097
* #1098
* #1099
* #1100
* #1102
* #1103
* #1104
* #1105
* #1106
* #1109
* #1110
* #1111
* #1112
* #1114
* #1116
* #1117
* #1118
* #1119
* #1120
* #1121
* #1122
* #1123
* #1125
* #1126
* #1127
* #1128
* #1129
* #1130
* #1131
* #1132
* #1133
* #1134
* #1135
* #1136
* #1138
* #1139
* #1140
* #1141
* #1142
* #1143
* #1144
* #1145
* #1146
* #1147
* #1148
* #1149
* #1151
* #1152
* #1153
* #1154
* #1155
* #1156
* #1157
* #1158
* #1160
* #1161
* #1162
* #1163
* #1164
* #1165
* #1166
* #1167
* #1168
* #1169
* #1170
* #1171
* #1172
* #1173
* #1174
* #1175
* #1177
* #1178
* #1180
* #1181
* #1182
* #1183
* #1184
* #1185
* #1187
* #1188
* #1189
* #1190
* #1191
* #1192
* #1193
* #1194
* #1195
* #1196
* #1198
* #1199
* #1200
* #1201
* #1203
* #1204
* #1205
* #1206
* #1207
* #1208
* #1209
* #1210
* #1211
* #1212
* #1213
* #1214
* #1215
* #1216
* #1217
* #1219
* #1220
* #1221
* #1222
* #1223
* #1224
* #1225
* #1226
* #1227
* #1229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants