Release 0.10.3 #2501
Release 0.10.3 #2501
Conversation
Clear build folder on export and publish
Remove hard-coded screen sizes
Use schema for creation of framework elements
Always install latest compatible version of plugin
Move course validation to back-end for efficiency
Catch stream error
Prep for release
tomgreenfield
requested review from
taylortom,
dancgray and
canstudios-nicolaw
| return cb(null, true); | ||
| } | ||
|
|
||
| function iterateThroughChildren(parents, children) { |
There was a problem hiding this comment.
This seems to be getting false positives. Getting the following error on menus:
Menu 'menu' does not contain any articles
There was a problem hiding this comment.
(Just so I'm clear) Does the menu have any pages in it?
I did mention the error message for empty menus being slightly strange in #2489 (comment), but I think we said it was ok because pages will be added in order to add articles.
There was a problem hiding this comment.
Yes, the menu had a child page. The child page had a valid article, block and component.
There was a problem hiding this comment.
This sounds like a show-stopper. I'm not able to test this right now.
@tomgreenfield can you confirm if this is something you have noticed on your 0.10.3 server?
Do we know if this happens every time or only some of the time?
There was a problem hiding this comment.
It's every time for me, tried new course and import. All have sub menus with valid pages in the submenu.
Used a clean install of release/bugpatch branch, node v12.11.1, mongo v3.6.12, Firefox 72.
There was a problem hiding this comment.
Can replicate this, @canstudios-nicolaw.
Course validation fix
Lock dependencies to known working versions
|
Ready for re-review @dancgray & @canstudios-nicolaw; planning to leave open till Friday to give it a run on our production server. |
|
Thanks for sorting this @tomgreenfield. It wouldn't be an AT release without updating the release date in the Changelog at least once! |
PR for 0.10.3.