Lock dependencies to known working versions #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomgreenfield
requested review from
taylortom,
canstudios-nicolaw and
memeteli
|
This is very similar to #2500. How would you feel about adding the npm ci change so that we can kill two birds with one stone? |
canstudios-nicolaw
approved these changes
Feb 19, 2020
dancgray
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
package-lock.jsonto ensure new installations pull down known working versions of npm packages.This targets Mongoose 5.8.13 until #2504 is investigated and resolved.
Please test on a fresh install with no existing
package-lock.json.